add yankay to reviewers #9247
Merged
add yankay to reviewers #9247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/flake
k8s-ci-robot
added
the
size/XS
|
Awesome, thanks @yankay ! /approve |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks , I will try my best :-) |
enneitex
added a commit
to enneitex/kubespray
that referenced
this pull request
Sep 2, 2022
[CI] remove opensuse Leap from molecule test blocking CI (kubernetes-sigs#9229) Fixes for calico_datastore: etcd (kubernetes-sigs#9228) It seems that PR kubernetes-sigs#8839 broke `calico_datastore: etcd` when it removed ipamconfig support for etcd mode. This PR fixes some failing tasks when `calico_datastore == etcd`, but it does not restore ipamconfig support for calico in etcd mode. If someone wants to restore ipamconfig support for `calico_datastore: etcd` please submit a follow up PR for that. kube-vip shoud fail if kube_proxy_strict_arp is false in arp mod (kubernetes-sigs#9223) * fix-kube-vip-strict-arp * fix-kube-vip-strict-arp add runc v1.1.4 (kubernetes-sigs#9230) Fix typo. Fix kube_ovn_hw_offload value (kubernetes-sigs#9218) Fix cloud_init files for different distros (kubernetes-sigs#9232) Fix abort because calicoctl.sh is not a full path (kubernetes-sigs#9217) feat: add kubelet systemd service hardening option (kubernetes-sigs#9194) * feat: add kubelet systemd service hardening option * refactor: move variable name to kubelet_secure_addresses Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com> * docs: add diagram about kubelet_secure_addresses variable Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com> make calico installation more stable (kubernetes-sigs#9227) Signed-off-by: hang.jiang <hang.jiang@daocloud.io> Signed-off-by: hang.jiang <hang.jiang@daocloud.io> Update security contacts file (kubernetes-sigs#9235) disable kubelet_authorization_mode_webhook by default (kubernetes-sigs#9238) add-yankay-to-reviewers (kubernetes-sigs#9247)
enneitex
added a commit
to enneitex/kubespray
that referenced
this pull request
Jan 25, 2023
[CI] remove opensuse Leap from molecule test blocking CI (kubernetes-sigs#9229) Fixes for calico_datastore: etcd (kubernetes-sigs#9228) It seems that PR kubernetes-sigs#8839 broke `calico_datastore: etcd` when it removed ipamconfig support for etcd mode. This PR fixes some failing tasks when `calico_datastore == etcd`, but it does not restore ipamconfig support for calico in etcd mode. If someone wants to restore ipamconfig support for `calico_datastore: etcd` please submit a follow up PR for that. kube-vip shoud fail if kube_proxy_strict_arp is false in arp mod (kubernetes-sigs#9223) * fix-kube-vip-strict-arp * fix-kube-vip-strict-arp add runc v1.1.4 (kubernetes-sigs#9230) Fix typo. Fix kube_ovn_hw_offload value (kubernetes-sigs#9218) Fix cloud_init files for different distros (kubernetes-sigs#9232) Fix abort because calicoctl.sh is not a full path (kubernetes-sigs#9217) feat: add kubelet systemd service hardening option (kubernetes-sigs#9194) * feat: add kubelet systemd service hardening option * refactor: move variable name to kubelet_secure_addresses Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com> * docs: add diagram about kubelet_secure_addresses variable Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com> make calico installation more stable (kubernetes-sigs#9227) Signed-off-by: hang.jiang <hang.jiang@daocloud.io> Signed-off-by: hang.jiang <hang.jiang@daocloud.io> Update security contacts file (kubernetes-sigs#9235) disable kubelet_authorization_mode_webhook by default (kubernetes-sigs#9238) add-yankay-to-reviewers (kubernetes-sigs#9247)
nolimitkun
pushed a commit
to nolimitkun/kubespray
that referenced
this pull request
Mar 19, 2023
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
What this PR does / why we need it:
I'd like to propose to be a reviewer for the kubespray project.
And also want to give more effective comments on the PRs to make Kubespray better.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: