Avoid MetalLB speaker image download when MetalLB speaker is disabled

[unai-ttxu]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Both MetalLB controller and MetalLB speaker are downloaded when metallb_enabled: true since #8715.

Since MetalLB speaker can be disabled, its image should be only downloaded when metallb_speaker_enabled: true

[MetalLB] Avoid MetalLB speaker image download when MetalLB speaker is disabled

[k8s-ci-robot]

Hi @unai-ttxu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[floryut]

@unai-ttxu Thank you
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, unai-ttxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oomichi]

@unai-ttxu Could you rebase this pull request based on the latest master branch to pass those test jobs?

[unai-ttxu]

@unai-ttxu Could you rebase this pull request based on the latest master branch to pass those test jobs?

Done!

[unai-ttxu]

Hi @oomichi @floryut can we check this PR?

I've just rebase it again 😄

[oomichi]

molecule_docker job is failed like:

fatal: [ubuntu20]: FAILED! => {
"msg": "The task includes an option with an undefined variable. The error was: {{ ...
'groups': ['kube_control_plane']}}: 
'metallb_speaker_enabled' is undefined
The error appears to be in '/builds/kargo-ci/kubernetes-sigs-kubespray/roles/download/tasks/download_file.yml': line 7, column 5, but may be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
  - name: download_file | Starting download of file
    ^ here\n"}

So we might need to move metallb_speaker_enabled to roles/kubespray-defaults/defaults/main.yaml to solve this issue.

[unai-ttxu]

molecule_docker job is failed like:

fatal: [ubuntu20]: FAILED! => {
"msg": "The task includes an option with an undefined variable. The error was: {{ ...
'groups': ['kube_control_plane']}}: 
'metallb_speaker_enabled' is undefined
The error appears to be in '/builds/kargo-ci/kubernetes-sigs-kubespray/roles/download/tasks/download_file.yml': line 7, column 5, but may be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
  - name: download_file | Starting download of file
    ^ here\n"}

So we might need to move metallb_speaker_enabled to roles/kubespray-defaults/defaults/main.yaml to solve this issue.

Done! Thanks for the help @oomichi 😄

[oomichi]

In this case(default true), metallb_speaker would be downloaded even if metallb is disabled. Right?
I guess it is better to use metallb_enabled value for metallb_speaker_enabled by default.

[unai-ttxu]

Good catch, you're wright!

I also decided to refactor all metallb_speaker_enabled references to be set to metallb_speaker_enabled: "{{ metallb_enabled }}" since enabling metallb_speaker_enabled only make sense when enabling metallb_enabled.

What do you think about it?

[oomichi]

Thanks for doing that, I think that is a nice idea.

/lgtm