-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download coredns image to all hosts in k8s_cluster #9316
Download coredns image to all hosts in k8s_cluster #9316
Conversation
|
Welcome @joes! |
Hi @joes. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @joes , please ensure to sign the CLA so we can accept this contribution. |
@cristicalin I did it online and got an email - am I supposed to mail the agreement to someone or is it just a matter of retriggering the check somehow? |
/easycla |
Seems the commit has the wrong e-mail address associated with it and easycla fails due to this. I will revert the branch commit and redo the commit and pull request with the correct details. |
Coredns image must be available everywhere as it may be rescheduled to a non-control-plane-node.
Using our own fork of kubespray now to work around this. Is there anything else for me to do to get this minor change merged @cristicalin? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joes Sorry I missed this PR; fine by me
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, joes, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Thanks @joes . |
Coredns image must be made available everywhere as it may be rescheduled to a non-control-plane-node.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #9315
Special notes for your reviewer:
Does this PR introduce a user-facing change?: