Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download coredns image to all hosts in k8s_cluster #9316

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Download coredns image to all hosts in k8s_cluster #9316

merged 1 commit into from
Oct 8, 2022

Conversation

joes
Copy link
Contributor

@joes joes commented Sep 23, 2022

Coredns image must be made available everywhere as it may be rescheduled to a non-control-plane-node.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #9315

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Download coredns image to all hosts in k8s_cluster

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 23, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 23, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: joes / name: Joe Siponen (d4fbbdc)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 23, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @joes!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 23, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @joes. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2022
@cristicalin
Copy link
Contributor

Hi @joes , please ensure to sign the CLA so we can accept this contribution.

@joes
Copy link
Contributor Author

joes commented Sep 23, 2022

@cristicalin I did it online and got an email - am I supposed to mail the agreement to someone or is it just a matter of retriggering the check somehow?

@joes
Copy link
Contributor Author

joes commented Sep 24, 2022

/easycla

@joes
Copy link
Contributor Author

joes commented Sep 24, 2022

Seems the commit has the wrong e-mail address associated with it and easycla fails due to this. I will revert the branch commit and redo the commit and pull request with the correct details.

Coredns image must be available everywhere as it
may be rescheduled to a non-control-plane-node.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 24, 2022
@joes
Copy link
Contributor Author

joes commented Oct 5, 2022

Using our own fork of kubespray now to work around this.

Is there anything else for me to do to get this minor change merged @cristicalin?

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joes Sorry I missed this PR; fine by me
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 5, 2022
@floryut floryut added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Oct 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, joes, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yankay
Copy link
Member

yankay commented Oct 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2022
@yankay
Copy link
Member

yankay commented Oct 8, 2022

Thanks @joes .

@k8s-ci-robot k8s-ci-robot merged commit 717b8da into kubernetes-sigs:master Oct 8, 2022
@floryut floryut mentioned this pull request Jan 4, 2023
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
)

Coredns image must be available everywhere as it
may be rescheduled to a non-control-plane-node.
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
)

Coredns image must be available everywhere as it
may be rescheduled to a non-control-plane-node.
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
)

Coredns image must be available everywhere as it
may be rescheduled to a non-control-plane-node.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coredns image should be pre-provisioned/downloaded onto all nodes (not only kube_control_plane)
5 participants