Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_typo job #9361

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Oct 7, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

To block merging pull requests which contain typo automatically.

Which issue(s) this PR fixes:

Fixes #9277

Does this PR introduce a user-facing change?:

[CI] Add check_typo job (and fix a bunch of typos)

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 7, 2022
@oomichi oomichi force-pushed the add-check-typo branch 2 times, most recently from 4064b23 to 2db61ed Compare October 7, 2022 07:09
@oomichi
Copy link
Contributor Author

oomichi commented Oct 7, 2022

Typos are found:

docs/ansible.md:284:87: "useage" is a misspelling of "usage"
docs/centos.md:5:27: "offically" is a misspelling of "officially"
docs/vars.md:186:136: "overriden" is a misspelling of "overridden"
roles/container-engine/containerd-common/defaults/main.yml:7:32: "arround" is a misspelling of "around"
roles/container-engine/kata-containers/templates/configuration-qemu.toml.j2:462:2: "explicity" is a misspelling of "explicitly"
roles/kubernetes/preinstall/templates/chrony.conf.j2:15:2: "Usefull" is a misspelling of "Useful"
roles/kubernetes/preinstall/templates/ntp.conf.j2:9:32: "Usefull" is a misspelling of "Useful"

To block merging pull requests which contain typo automatically.
@oomichi oomichi marked this pull request as ready for review October 7, 2022 07:21
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2022
@k8s-ci-robot k8s-ci-robot requested review from EppO and pasqualet October 7, 2022 07:21
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2022
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thank you @oomichi
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, oomichi, pasqualet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 24632ae into kubernetes-sigs:master Oct 7, 2022
@floryut floryut mentioned this pull request Jan 4, 2023
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
To block merging pull requests which contain typo automatically.
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
To block merging pull requests which contain typo automatically.
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
To block merging pull requests which contain typo automatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: CI Robot for spell check
4 participants