-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cinder-csi-nodeplugin): Remove the pods-cloud-data volume #9362
Conversation
Hi @huangkevin404. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huangkevin404 Thank you
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, huangkevin404 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Thanks @huangkevin404 ! /lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This removes the pods-cloud-data volume in cinder-csi-nodeplugin because it was removed in upstream (See kubernetes/cloud-provider-openstack#1182). Without removing this, the csi-cinder-nodeplugin pods are stuck on ContainerCreating because /var/lib/cloud/data does not exist on the host anymore.
Does this PR introduce a user-facing change?: