Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(defaults): wrong cri_socket path for containerd #9401

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

maxime1907
Copy link
Contributor

@maxime1907 maxime1907 commented Oct 17, 2022

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes the wrong default values of cri_socket that was setting 4 / instead of 3 /
We need this PR because kubelet is throwing errors with the default configuration as described below:

Oct 17 13:58:56 kube-test-sandbox-node-002 kubelet[2401900]: I1017 13:58:56.831825 2401900 remote_runtime.go:71] "Connecting to runtime service" endpoint="unix:////var/run/containerd/containerd.sock"
Oct 17 13:58:56 kube-test-sandbox-node-002 kubelet[2401900]: I1017 13:58:56.831876 2401900 clientconn.go:252] "[core] parsed scheme: \"\"\n"
Oct 17 13:58:56 kube-test-sandbox-node-002 kubelet[2401900]: I1017 13:58:56.831890 2401900 clientconn.go:258] "[core] scheme \"\" not registered, fallback to default scheme\n"

It also puts misleading annotations on nodes:

kubeadm.alpha.kubernetes.io/cri-socket: unix:////var/run/containerd/containerd.sock

Does this PR introduce a user-facing change?:

Fix wrong cri_socket path for containerd

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 17, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 17, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: maxime1907 / name: Maxime Leroy (dc9d272)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 17, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 17, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @maxime1907. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 17, 2022
@yankay
Copy link
Member

yankay commented Oct 18, 2022

/lgtm

Thanks @maxime1907

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2022
@liupeng0518
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 18, 2022
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, maxime1907

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit d9c39c2 into kubernetes-sigs:master Oct 18, 2022
salifou pushed a commit to salifou/kubespray that referenced this pull request Nov 13, 2022
@floryut floryut mentioned this pull request Jan 4, 2023
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants