Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flannel: fix init container image arch #9461

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

rollandf
Copy link
Contributor

@rollandf rollandf commented Nov 2, 2022

The install-cni-plugin image was not updated to the corresponding arch when building the different DS.

Fixes issue #9460

Signed-off-by: Fred Rolland frolland@nvidia.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #9460

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[Flannel] Initcontainer image now correctly support architecture suffix

The install-cni-plugin image was not updated to the corresponding
arch when building the different DS.

Fixes issue kubernetes-sigs#9460

Signed-off-by: Fred Rolland <frolland@nvidia.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 2, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @rollandf!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 2, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @rollandf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2022
@rollandf
Copy link
Contributor Author

rollandf commented Nov 2, 2022

With this patch:

root@dcm-cp-1:~# kubectl get ds -n kube-system kube-flannel-ds-ppc64le -o json | jq .spec.template.spec.initContainers[0].image
"docker.io/flannelcni/flannel-cni-plugin:v1.1.0-ppc64le"
root@dcm-cp-1:~# 
root@dcm-cp-1:~# kubectl get ds -n kube-system kube-flannel-ds-arm64 -o json | jq .spec.template.spec.initContainers[0].image
"docker.io/flannelcni/flannel-cni-plugin:v1.1.0-arm64"

@yankay
Copy link
Member

yankay commented Nov 3, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2022
@yankay
Copy link
Member

yankay commented Nov 3, 2022

Thanks @rollandf

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2022
@floryut floryut added the kind/network Network section in the release note label Nov 3, 2022
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rollandf Thank you for the PR 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, rollandf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 58faef6 into kubernetes-sigs:master Nov 3, 2022
salifou pushed a commit to salifou/kubespray that referenced this pull request Nov 13, 2022
The install-cni-plugin image was not updated to the corresponding
arch when building the different DS.

Fixes issue kubernetes-sigs#9460

Signed-off-by: Fred Rolland <frolland@nvidia.com>

Signed-off-by: Fred Rolland <frolland@nvidia.com>
@floryut floryut mentioned this pull request Jan 4, 2023
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
The install-cni-plugin image was not updated to the corresponding
arch when building the different DS.

Fixes issue kubernetes-sigs#9460

Signed-off-by: Fred Rolland <frolland@nvidia.com>

Signed-off-by: Fred Rolland <frolland@nvidia.com>
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
The install-cni-plugin image was not updated to the corresponding
arch when building the different DS.

Fixes issue kubernetes-sigs#9460

Signed-off-by: Fred Rolland <frolland@nvidia.com>

Signed-off-by: Fred Rolland <frolland@nvidia.com>
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
The install-cni-plugin image was not updated to the corresponding
arch when building the different DS.

Fixes issue kubernetes-sigs#9460

Signed-off-by: Fred Rolland <frolland@nvidia.com>

Signed-off-by: Fred Rolland <frolland@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CNI Flannel - Arch image handling is missing for init-container install-cni-plugin
4 participants