Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update local-volume-provisioner + doc #9463

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Update local-volume-provisioner + doc #9463

merged 1 commit into from
Nov 7, 2022

Conversation

olivierlemasle
Copy link
Member

@olivierlemasle olivierlemasle commented Nov 2, 2022 •
edited by floryut
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Update and re-work the documentation:
    • Update project link
    • Fix formatting (especially for lists)
    • Remove outdated documentation:
      • useAlphaApi flag: only for k8s versions < v1.10
      • Limitation about volume size calculation is outdated
    • Attempt to clarify the doc
  • Update to version 1.5.0
  • Remove PodSecurityPolicy (deprecated in k8s v1.21+)
  • Update ClusterRole following upstream
  • Add nodeSelector to DaemonSet following upstream

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update local-volume-provisioner to 2.5.0 + add documentation

@olivierlemasle
Update local-volume-provisioner
2cde1f0 
- Update and re-work the documentation:
  - Update links
  - Fix formatting (especially for lists)
  - Remove documentation about `useAlphaApi`,
    a flag only for k8s versions < v1.10
  - Attempt to clarify the doc
- Update to version 1.5.0
- Remove PodSecurityPolicy (deprecated in k8s v1.21+)
- Update ClusterRole following upstream
  (cf kubernetes-sigs/sig-storage-local-static-provisioner#292)
- Add nodeSelector to DaemonSet (following upstream)
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 2, 2022
@yankay
Copy link
Member

yankay commented Nov 3, 2022

Thanks @olivierlemasle
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2022
@olivierlemasle
Copy link
Member Author

/assign @mattymo

oomichi
oomichi reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some nit comments.
It is fine to apply them later.

/approve

docs/kubernetes-apps/local_volume_provisioner.md
@@ -1,10 +1,11 @@
# Local Storage Provisioner
# Local Static Storage Provisioner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Local Static Storage Provisioner
# Local Persistence Volume Static Provisioner

as the title of https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner

docs/kubernetes-apps/local_volume_provisioner.md

The [local storage provisioner](https://github.com/kubernetes-incubator/external-storage/tree/master/local-volume)
The [local static storage provisioner](https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olivierlemasle, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@oomichi
Copy link
Contributor

oomichi commented Nov 7, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5d1fe64 into kubernetes-sigs:master Nov 7, 2022
@oomichi oomichi mentioned this pull request Nov 7, 2022
Closed
@olivierlemasle olivierlemasle deleted the localvol branch November 7, 2022 23:42
@olivierlemasle
Copy link
Member Author

Thank you @oomichi, I'll open a follow-up PR to rename the provisioner as you requested.

salifou pushed a commit to salifou/kubespray that referenced this pull request Nov 13, 2022
@olivierlemasle @salifou
Update local-volume-provisioner (kubernetes-sigs#9463)
2164e98 
- Update and re-work the documentation:
  - Update links
  - Fix formatting (especially for lists)
  - Remove documentation about `useAlphaApi`,
    a flag only for k8s versions < v1.10
  - Attempt to clarify the doc
- Update to version 1.5.0
- Remove PodSecurityPolicy (deprecated in k8s v1.21+)
- Update ClusterRole following upstream
  (cf kubernetes-sigs/sig-storage-local-static-provisioner#292)
- Add nodeSelector to DaemonSet (following upstream)
@floryut floryut mentioned this pull request Jan 4, 2023
Closed
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
@olivierlemasle @enneitex
Update local-volume-provisioner (kubernetes-sigs#9463)
6346c5b 
- Update and re-work the documentation:
  - Update links
  - Fix formatting (especially for lists)
  - Remove documentation about `useAlphaApi`,
    a flag only for k8s versions < v1.10
  - Attempt to clarify the doc
- Update to version 1.5.0
- Remove PodSecurityPolicy (deprecated in k8s v1.21+)
- Update ClusterRole following upstream
  (cf kubernetes-sigs/sig-storage-local-static-provisioner#292)
- Add nodeSelector to DaemonSet (following upstream)
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@olivierlemasle @HoKim98
Update local-volume-provisioner (kubernetes-sigs#9463)
6ec4b62 
- Update and re-work the documentation:
  - Update links
  - Fix formatting (especially for lists)
  - Remove documentation about `useAlphaApi`,
    a flag only for k8s versions < v1.10
  - Attempt to clarify the doc
- Update to version 1.5.0
- Remove PodSecurityPolicy (deprecated in k8s v1.21+)
- Update ClusterRole following upstream
  (cf kubernetes-sigs/sig-storage-local-static-provisioner#292)
- Add nodeSelector to DaemonSet (following upstream)
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@olivierlemasle @nolimitkun
Update local-volume-provisioner (kubernetes-sigs#9463)
f0ff284 
- Update and re-work the documentation:
  - Update links
  - Fix formatting (especially for lists)
  - Remove documentation about `useAlphaApi`,
    a flag only for k8s versions < v1.10
  - Attempt to clarify the doc
- Update to version 1.5.0
- Remove PodSecurityPolicy (deprecated in k8s v1.21+)
- Update ClusterRole following upstream
  (cf kubernetes-sigs/sig-storage-local-static-provisioner#292)
- Add nodeSelector to DaemonSet (following upstream)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@cristicalin cristicalin Awaiting requested review from cristicalin

Assignees

@mattymo mattymo

@yankay yankay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@olivierlemasle @yankay @k8s-ci-robot @oomichi @mattymo