Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop calico v3.21 support #9515

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Nov 22, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

At the upstream calico development, the v3.21 branch is not updated over 2 monthes.
In addition, unnecessary error message is output at Kubespray deployment due to different URLs for calico v3.21 or v3.22+.
This drops the v3.21 support to solve the issue.

Which issue(s) this PR fixes:

Fixes #9514

Special notes for your reviewer:

#9473 is for adding newer version support of calico.

Does this PR introduce a user-facing change?:

Drop calico v3.21 support

At the upstream calico development, the v3.21 branch is not updated
over 2 monthes. In addition, unnecessary error message is output at
Kubespray deployment due to different URLs for calico v3.21 or v3.22+
This drops the v3.21 support to solve the issue.
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 22, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2022
@oomichi
Copy link
Contributor Author

oomichi commented Nov 22, 2022

@cristicalin has taken huge effort for this area.
I'd like to see his opinion before merging.

/cc @cristicalin
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2022
@floryut
Copy link
Member

floryut commented Dec 27, 2022

@cristicalin has taken huge effort for this area. I'd like to see his opinion before merging.

/cc @cristicalin /hold

Should we push this one forward ? as Cristian is not available lately

@oomichi
Copy link
Contributor Author

oomichi commented Dec 28, 2022

@cristicalin has taken huge effort for this area. I'd like to see his opinion before merging.
/cc @cristicalin /hold

Should we push this one forward ? as Cristian is not available lately

I see. It is fine to go forward with us in the community.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 28, 2022
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 61be93b into kubernetes-sigs:master Dec 29, 2022
@floryut floryut mentioned this pull request Jan 4, 2023
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
At the upstream calico development, the v3.21 branch is not updated
over 2 monthes. In addition, unnecessary error message is output at
Kubespray deployment due to different URLs for calico v3.21 or v3.22+
This drops the v3.21 support to solve the issue.
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
At the upstream calico development, the v3.21 branch is not updated
over 2 monthes. In addition, unnecessary error message is output at
Kubespray deployment due to different URLs for calico v3.21 or v3.22+
This drops the v3.21 support to solve the issue.
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
At the upstream calico development, the v3.21 branch is not updated
over 2 monthes. In addition, unnecessary error message is output at
Kubespray deployment due to different URLs for calico v3.21 or v3.22+
This drops the v3.21 support to solve the issue.
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
At the upstream calico development, the v3.21 branch is not updated
over 2 monthes. In addition, unnecessary error message is output at
Kubespray deployment due to different URLs for calico v3.21 or v3.22+
This drops the v3.21 support to solve the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calicoctl Download - 404 Not found
3 participants