Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex for comments nameserver in resolv.conf #9523

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Fix regex for comments nameserver in resolv.conf #9523

merged 1 commit into from
Nov 30, 2022

Conversation

yankay
Copy link
Member

@yankay yankay commented Nov 28, 2022 •
edited by floryut
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

When the resolv.conf is like

nameserver 1.1.1.1
#nameserver 2.2.2.2

There is an error that, both 1.1.1.1 and 2.2.2.2 would be considered as the nameserver,

So the PR is to fix the errer.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix regex for comments nameserver in resolv.conf

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2022
@oomichi
Copy link
Contributor

oomichi commented Nov 30, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4db5e66 into kubernetes-sigs:master Nov 30, 2022
@yankay
Copy link
Member Author

yankay commented Dec 1, 2022

Thanks @floryut @oomichi for your PR review

@floryut floryut mentioned this pull request Jan 4, 2023
Closed
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
@yankay @enneitex
fix-mistake-regex-for-resolv-conf (kubernetes-sigs#9523)
8c1c2c4
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@yankay @HoKim98
fix-mistake-regex-for-resolv-conf (kubernetes-sigs#9523)
c538170
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@yankay @nolimitkun
fix-mistake-regex-for-resolv-conf (kubernetes-sigs#9523)
7cbfedc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@cristicalin cristicalin Awaiting requested review from cristicalin

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yankay @k8s-ci-robot @oomichi @floryut