Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ingress-nginx] upgrade to 1.5.1 #9532

Merged

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Nov 30, 2022

What type of PR is this? /kind feature

What this PR does / why we need it:
Upgrade ingress-nginx-controller to 1.5.1 https://github.com/kubernetes/ingress-nginx/releases/tag/controller-v1.5.1

Does this PR introduce a user-facing change?:

[ingress-nginx] upgrade to 1.5.1

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 30, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 30, 2022
@oomichi oomichi added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 1, 2022
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment.
I am wondersing why the check script didn't detect this mismatch.

README.md Outdated Show resolved Hide resolved
@oomichi
Copy link
Contributor

oomichi commented Dec 1, 2022

just one comment. I am wondersing why the check script didn't detect this mismatch.

I found the above reason. I created a pull request for detecting the mismatch as #9533
I will update it again after merging this pr.

@oomichi
Copy link
Contributor

oomichi commented Dec 1, 2022

#9533 has been merged already.
Please rebase this pull request on the latest master branch and update the README.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2022
@mzaian mzaian force-pushed the ingress-nginx-controller-v1.5.1 branch from 152dbfa to 1943030 Compare December 1, 2022 15:43
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2022
@oomichi
Copy link
Contributor

oomichi commented Dec 1, 2022

Thanks for updating.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2022
@yankay
Copy link
Member

yankay commented Dec 2, 2022

Thanks @Mazian
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, oomichi, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oomichi
Copy link
Contributor

oomichi commented Dec 2, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit bca601d into kubernetes-sigs:master Dec 2, 2022
@mzaian mzaian mentioned this pull request Jan 6, 2023
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants