-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metrics_server]: Enabled HA mode by adding 'metrics_server_replicas'… #9539
Conversation
… variable and adding podAntiAffinity rule Signed-off-by: Ugur Can Ozturk <57688057+ugur99@users.noreply.github.com>
|
Welcome @ugur99! |
Hi @ugur99. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
roles/kubernetes-apps/metrics_server/templates/metrics-server-deployment.yaml.j2
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ugur99 Thank you for the PR!
That's a good feature to bring back from the dead 🧟
roles/kubernetes-apps/metrics_server/templates/metrics-server-deployment.yaml.j2
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, ugur99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ugur Can Ozturk <57688057+ugur99@users.noreply.github.com>
Thanks @ugur99 very much /lgtm |
kubernetes-sigs#9539) * [metrics_server]: Enabled HA mode by adding 'metrics_server_replicas' variable and adding podAntiAffinity rule Signed-off-by: Ugur Can Ozturk <57688057+ugur99@users.noreply.github.com> * [metrics_server]: added namespaces selector Signed-off-by: Ugur Can Ozturk <57688057+ugur99@users.noreply.github.com> Signed-off-by: Ugur Can Ozturk <57688057+ugur99@users.noreply.github.com>
kubernetes-sigs#9539) * [metrics_server]: Enabled HA mode by adding 'metrics_server_replicas' variable and adding podAntiAffinity rule Signed-off-by: Ugur Can Ozturk <57688057+ugur99@users.noreply.github.com> * [metrics_server]: added namespaces selector Signed-off-by: Ugur Can Ozturk <57688057+ugur99@users.noreply.github.com> Signed-off-by: Ugur Can Ozturk <57688057+ugur99@users.noreply.github.com>
kubernetes-sigs#9539) * [metrics_server]: Enabled HA mode by adding 'metrics_server_replicas' variable and adding podAntiAffinity rule Signed-off-by: Ugur Can Ozturk <57688057+ugur99@users.noreply.github.com> * [metrics_server]: added namespaces selector Signed-off-by: Ugur Can Ozturk <57688057+ugur99@users.noreply.github.com> Signed-off-by: Ugur Can Ozturk <57688057+ugur99@users.noreply.github.com>
Signed-off-by: Ugur Can Ozturk ugurozturk918@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
We were looking for a parameter to deploy
metrics_server
in HA mode with KubeSpray and discovered the issue; wanted to contribute with this PR.The small feature provides usage of metrics_server in HA mode by manipulating the number of replicas, also nodeAffinity rule which prioritizes running replicas on control_planes was removed, and instead of it, the podAntiAffinity rule was added.
Which issue(s) this PR fixes:
Fixes #9197
Special notes for your reviewer:
Tested by installing a new cluster.
Does this PR introduce a user-facing change?: