Skip retry operation with containerd when etcd installed on host VM #9560

JRaver · 2022-12-09T13:02:56Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug
When etcd installed on host VM and we use containerd in K8S, Kubespray always retry crictl for 5 time, it's took additional time when you delete your cluster .

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

k8s-ci-robot · 2022-12-09T13:03:04Z

Hi @JRaver. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yankay · 2022-12-12T06:01:29Z

/ok-to-test

JRaver · 2023-01-05T09:12:13Z

@floryut @bozzo @oomichi Can you review this PR please and add to the release proposal to the new Kubespray version. Thanks

oomichi · 2023-01-05T11:09:30Z

I could not get the point of this pull request.
This pull request description shows skipping containerd retry if etcd is installed on host VM.
However, this pull request adds a condition for checking containerd.service, not whether etcd is installed on host VM or not.

JRaver · 2023-01-05T11:28:37Z

Because this playbook running on hosts - ((etcd:k8s_cluster:calico_rr) and for this reason I add this check, because if you're trying to run crictl command on hosts where isn't installed contanerd , this step will retry for 5 times *2, and this add additional 10 minutes to deleting process

P.S. In our CICD process we use to reinstall sandbox cluster many times, this pr help us save time

oomichi · 2023-01-05T23:06:11Z

Because this playbook running on hosts - ((etcd:k8s_cluster:calico_rr) and for this reason I add this check, because if you're trying to run crictl command on hosts where isn't installed contanerd , this step will retry for 5 times *2, and this add additional 10 minutes to deleting process

P.S. In our CICD process we use to reinstall sandbox cluster many times, this pr help us save time

I see the point, thanks for your explanation.
It is fine to merge this pull request for me now.

/ok-to-test
/lgtm

floryut · 2023-01-06T07:55:10Z

roles/reset/tasks/main.yml

@@ -80,6 +81,7 @@
    - crictl.stat.exists
    - container_manager in ["crio", "containerd"]
    - deploy_container_engine
+    - ansible_facts.services['containerd.service'] is defined


Won't this always be false on cri-o setups ?

thanks @floryut , updated PR,I forgot about cri-o, please take a look one more time

JRaver · 2023-01-10T08:50:44Z

@floryut review one more time please

floryut

@JRaver Thanks for updating

k8s-ci-robot · 2023-01-10T12:29:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, JRaver

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

oomichi · 2023-01-10T23:50:27Z

/lgtm

* Skip retry operation with containerd when etcd installed on host VM (#9560) Signed-off-by: bo.jiang <bo.jiang@daocloud.io> * Update cri-dockerd version Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Co-authored-by: Eugene Artemenko <artemenko.evgeniy@gmail.com>

…ubernetes-sigs#9560)

* Skip retry operation with containerd when etcd installed on host VM (kubernetes-sigs#9560) Signed-off-by: bo.jiang <bo.jiang@daocloud.io> * Update cri-dockerd version Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Co-authored-by: Eugene Artemenko <artemenko.evgeniy@gmail.com>

…ubernetes-sigs#9560)

* Skip retry operation with containerd when etcd installed on host VM (kubernetes-sigs#9560) Signed-off-by: bo.jiang <bo.jiang@daocloud.io> * Update cri-dockerd version Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Co-authored-by: Eugene Artemenko <artemenko.evgeniy@gmail.com>

…ubernetes-sigs#9560)

* Skip retry operation with containerd when etcd installed on host VM (kubernetes-sigs#9560) Signed-off-by: bo.jiang <bo.jiang@daocloud.io> * Update cri-dockerd version Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Co-authored-by: Eugene Artemenko <artemenko.evgeniy@gmail.com>

…ubernetes-sigs#9560)

* Skip retry operation with containerd when etcd installed on host VM (kubernetes-sigs#9560) Signed-off-by: bo.jiang <bo.jiang@daocloud.io> * Update cri-dockerd version Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Co-authored-by: Eugene Artemenko <artemenko.evgeniy@gmail.com>

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 9, 2022

k8s-ci-robot requested review from bozzo and oomichi December 9, 2022 13:03

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2022

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 12, 2022

JRaver mentioned this pull request Jan 5, 2023

Release Proposal v2.21 #9638

Closed

k8s-ci-robot assigned oomichi Jan 5, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2023

floryut reviewed Jan 6, 2023

View reviewed changes

Skip retry operation with containerd when etcd installed on host VM

a2b3a37

JRaver force-pushed the feature/skip_retry_containerd branch from f6953f8 to a2b3a37 Compare January 6, 2023 12:08

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2023

floryut approved these changes Jan 10, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2023

k8s-ci-robot merged commit 6f1352e into kubernetes-sigs:master Jan 10, 2023

enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023

Skip retry operation with containerd when etcd installed on host VM (k…

7026157

…ubernetes-sigs#9560)

HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023

Skip retry operation with containerd when etcd installed on host VM (k…

2780f46

…ubernetes-sigs#9560)

nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023

Skip retry operation with containerd when etcd installed on host VM (k…

30cd877

…ubernetes-sigs#9560)

pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024

Skip retry operation with containerd when etcd installed on host VM (k…

b4d1fbb

…ubernetes-sigs#9560)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip retry operation with containerd when etcd installed on host VM #9560

Skip retry operation with containerd when etcd installed on host VM #9560

JRaver commented Dec 9, 2022

k8s-ci-robot commented Dec 9, 2022

yankay commented Dec 12, 2022

JRaver commented Jan 5, 2023

oomichi commented Jan 5, 2023

JRaver commented Jan 5, 2023 •

edited

Loading

oomichi commented Jan 5, 2023

floryut Jan 6, 2023

JRaver Jan 6, 2023 •

edited

Loading

JRaver commented Jan 10, 2023

floryut left a comment

k8s-ci-robot commented Jan 10, 2023

oomichi commented Jan 10, 2023

Skip retry operation with containerd when etcd installed on host VM #9560

Skip retry operation with containerd when etcd installed on host VM #9560

Conversation

JRaver commented Dec 9, 2022

k8s-ci-robot commented Dec 9, 2022

yankay commented Dec 12, 2022

JRaver commented Jan 5, 2023

oomichi commented Jan 5, 2023

JRaver commented Jan 5, 2023 • edited Loading

oomichi commented Jan 5, 2023

floryut Jan 6, 2023

Choose a reason for hiding this comment

JRaver Jan 6, 2023 • edited Loading

Choose a reason for hiding this comment

JRaver commented Jan 10, 2023

floryut left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 10, 2023

oomichi commented Jan 10, 2023

JRaver commented Jan 5, 2023 •

edited

Loading

JRaver Jan 6, 2023 •

edited

Loading