-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove immutable flag from /var/lib/kubelet subdirs #9597
Remove immutable flag from /var/lib/kubelet subdirs #9597
Conversation
Hi @emiran-orange. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
packet_ubuntu20-calico-aio is failed like:
|
@oomichi Arff sorry for that, I split things into two tasks. That seems to work better |
6e163a6
to
37a4b28
Compare
Thanks for updating. /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: emiran-orange, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @emiran-orange |
…9597) * Remove immutable flag from /var/lib/kubelet subdirs * Find files before changing attributes
…9597) * Remove immutable flag from /var/lib/kubelet subdirs * Find files before changing attributes
…9597) * Remove immutable flag from /var/lib/kubelet subdirs * Find files before changing attributes
…9597) * Remove immutable flag from /var/lib/kubelet subdirs * Find files before changing attributes
What type of PR is this?
/kind bug
What this PR does / why we need it:
Before removing /var/lib/kubelet, make sure immutable flag (
chattr -i
) is removed from /var/lib/kubelet's tree.As a matter of fact, file module does not change attributes before removing the directory (hence the separate task before).
We need it because some CSI drivers set immutable flag on mount directories (at least some leftovers of those CSI driver have been found) in /var/lib/kubelet, and shutil.rmtree (which is used in file module when state is "absent") simply does not remove most of /var/lib/kubelet if only one dir is immutable in, for example, /var/lib/kubelets/pods. That causes node join to fail afterwards.
Which issue(s) this PR fixes:
None that I know of
Special notes for your reviewer:
I initially planned to remove immutable flag from all the list of files/dirs in "reset | delete some files and directories" task but that would have meant creating them if missing, I hope you find this way better.
Does this PR introduce a user-facing change?: