-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(coredns): Forward extra domains to coredns kubernetes plugin #9635
feat(coredns): Forward extra domains to coredns kubernetes plugin #9635
Conversation
Hi @mvandergiesen. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mvandergiesen Could you rebase as #9640 is now merged (Fixing the cri-o CI) ? |
The change itself seems good for me. /approve |
88fb994
to
36a0656
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, mvandergiesen, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
For our environment we would like to have a more granular method to specify the domains passed to the coredns kubernetes plugin. This pull-request adds an extra optional variable that will help users who want to fine-tune the configuration for a specific environment.
Does this PR introduce a user-facing change?: