Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(calico): add possibility to enable calico floatingIPs feature #9680

Merged
merged 1 commit into from
Jan 18, 2023
Merged

feat(calico): add possibility to enable calico floatingIPs feature #9680

merged 1 commit into from
Jan 18, 2023

Conversation

MatthieuFin
Copy link
Contributor

Add a variable calico_felix_floatingIPs which permit to enable calico feature floatingIPs (disabled per default).

#9679

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #9679

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

NONE

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 17, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 17, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @MatthieuFin!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 17, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @MatthieuFin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 17, 2023
oomichi
oomichi reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @oomichi

roles/network_plugin/calico/defaults/main.yml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot requested a review from oomichi January 18, 2023 00:18
@yankay
Copy link
Member

yankay commented Jan 18, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 18, 2023
@MatthieuFin
feat(calico): add possibility to enable calico floatingIPs feature
67dc5dd 
Add a variable `calico_felix_floatingIPs` which permit to enable calico feature `floatingIPs`
(disabled per default).

Signed-off-by: MatthieuFin <matthieu2717@gmail.com>

 kubernetes-sigs#9679
floryut
floryut approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatthieuFin Thank you for the PR 🚀

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyclinder, floryut, MatthieuFin, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@floryut floryut closed this Jan 18, 2023
@floryut floryut reopened this Jan 18, 2023
@oomichi
Copy link
Contributor

oomichi commented Jan 18, 2023

Thanks for updating.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 374438a into kubernetes-sigs:master Jan 18, 2023
@floryut floryut mentioned this pull request Jan 19, 2023
Closed
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
@MatthieuFin @enneitex
feat(calico): add possibility to enable calico floatingIPs feature (k…
a700814 
…ubernetes-sigs#9680)

Add a variable `calico_felix_floatingIPs` which permit to enable calico feature `floatingIPs`
(disabled per default).

Signed-off-by: MatthieuFin <matthieu2717@gmail.com>

 kubernetes-sigs#9679
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@MatthieuFin @HoKim98
feat(calico): add possibility to enable calico floatingIPs feature (k…
cdea97b 
…ubernetes-sigs#9680)

Add a variable `calico_felix_floatingIPs` which permit to enable calico feature `floatingIPs`
(disabled per default).

Signed-off-by: MatthieuFin <matthieu2717@gmail.com>

 kubernetes-sigs#9679
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@MatthieuFin @nolimitkun
feat(calico): add possibility to enable calico floatingIPs feature (k…
dd784ce 
…ubernetes-sigs#9680)

Add a variable `calico_felix_floatingIPs` which permit to enable calico feature `floatingIPs`
(disabled per default).

Signed-off-by: MatthieuFin <matthieu2717@gmail.com>

 kubernetes-sigs#9679
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@MatthieuFin @pedromcpedro
feat(calico): add possibility to enable calico floatingIPs feature (k…
a5d8b98 
…ubernetes-sigs#9680)

Add a variable `calico_felix_floatingIPs` which permit to enable calico feature `floatingIPs`
(disabled per default).

Signed-off-by: MatthieuFin <matthieu2717@gmail.com>

 kubernetes-sigs#9679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian mzaian approved these changes

@floryut floryut floryut approved these changes

@cyclinder cyclinder cyclinder approved these changes

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow enable calico floatingIPs feature
7 participants
@MatthieuFin @k8s-ci-robot @yankay @oomichi @mzaian @floryut @cyclinder