-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9693: Fix comma-separated-list splitting of kubelet_enforce_node_allocatable #9694
9693: Fix comma-separated-list splitting of kubelet_enforce_node_allocatable #9694
Conversation
Hi @Tristan971. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Nice catch! /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tristan971 Thank you for the PR 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, oomichi, Tristan971 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Fyi I didn’t make the PR target the release branch, so I assume you’ll deal with cherry-picking it there or however it goes for a 2.21.1 (picking it on the branch would be easiest, so I don’t have to deal with changing my submodules refs to my fork 🥲) |
We could as I plan to release quickly a 2.21.1 after backporting #9697 (seems important enough to create a patch release) |
@Tristan971 Would you be kind enough to create the backport PR ? (for this one obviously) |
Sure 👍 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes improper splitting of comma-separated list in
kubelet_enforce_node_allocatable
Before:
After:
Which issue(s) this PR fixes:
Fixes #9693
Special notes for your reviewer:
Does this PR introduce a user-facing change?: