Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9693: Fix comma-separated-list splitting of kubelet_enforce_node_allocatable #9694

Conversation

Tristan971
Copy link
Contributor

@Tristan971 Tristan971 commented Jan 20, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Fixes improper splitting of comma-separated list in kubelet_enforce_node_allocatable

Before:

$ cat /etc/kubernetes/kubelet-config.yaml | grep -A4 enforceNode
enforceNodeAllocatable: "pods,kube-reserved,system-reserved"
staticPodPath: /etc/kubernetes/manifests

After:

$ cat /etc/kubernetes/kubelet-config.yaml | grep -A4 enforceNode
enforceNodeAllocatable:
- pods
- kube-reserved
- system-reserved
staticPodPath: /etc/kubernetes/manifests

Which issue(s) this PR fixes:

Fixes #9693

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix comma-separated-list splitting of `kubelet_enforce_node_allocatable` variable

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Tristan971. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2023
@Tristan971 Tristan971 changed the title 9693: Fix comma-separated-list splitting of kubelet_enforce_node_allo… 9693: Fix comma-separated-list splitting of kubelet_enforce_node_allocatable Jan 20, 2023
@oomichi
Copy link
Contributor

oomichi commented Jan 22, 2023

Nice catch!

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tristan971 Thank you for the PR 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, oomichi, Tristan971

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oomichi
Copy link
Contributor

oomichi commented Jan 24, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2023
@Tristan971
Copy link
Contributor Author

Tristan971 commented Jan 24, 2023

Fyi I didn’t make the PR target the release branch, so I assume you’ll deal with cherry-picking it there or however it goes for a 2.21.1

(picking it on the branch would be easiest, so I don’t have to deal with changing my submodules refs to my fork 🥲)

@k8s-ci-robot k8s-ci-robot merged commit 5fbbced into kubernetes-sigs:master Jan 24, 2023
@floryut
Copy link
Member

floryut commented Jan 24, 2023

Fyi I didn’t make the PR target the release branch, so I assume you’ll deal with cherry-picking it there or however it goes for a 2.21.1

(picking it on the branch would be easiest, so I don’t have to deal with changing my submodules refs to my fork 🥲)

We could as I plan to release quickly a 2.21.1 after backporting #9697 (seems important enough to create a patch release)

@floryut
Copy link
Member

floryut commented Jan 24, 2023

@Tristan971 Would you be kind enough to create the backport PR ? (for this one obviously)

@Tristan971
Copy link
Contributor Author

Sure 👍

pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect list splitting in kubelet config template
4 participants