[Need Discuss] Fix containerd config_path error when containerd_registries is configed

[yankay]

What type of PR is this?

/kind bug

What this PR does / why we need it:

After the #9566
There is a warning log when start the containerd:

containerd[58616]: time="2023-01-31T21:05:15.041655133Z" level=warning 
  msg="failed to load plugin io.containerd.grpc.v1.cri" 
  error="invalid plugin config: `mirrors` cannot be set when `config_path` is provided"

When the containerd_insecure_registries or containerd_registries are configured, the kubeadm can not install the Kubernetes. And kubelet can not start the Pod.

So the PR is try to fix the bug, following the https://github.com/containerd/containerd/blob/main/docs/hosts.md.

Which issue(s) this PR fixes:

Fixes #9741

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yankay]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yankay]

From the

• https://github.com/containerd/containerd/blob/main/pkg/cri/config/config.go#L459
• https://github.com/containerd/containerd/blob/main/pkg/cri/server/image_pull.go#L384

The config_path and registry.mirror cannot work together.

And the registry.mirror can still be used in containerd 1.x, containerd 1.7 is intended to be the last major release of containerd 1.x before 2.0.

”Removal of this and other deprecations are not immediate. Yes, we've been considering removing all v1 deprecations when we move to v2, yes perhaps EOY perhaps sometime next year. We've been discussing the possibility of providing migration tooling for config and metadata. It is just as likely we will attempt to carry v1 and early v2 release versions of certain services (esp. CRI) at the same time to allow for opt in testing. The hosts.toml config is very similar to docker hosts.toml, if that helps.
"
From the kubernetes/kubernetes#110312 (comment)_

So there is another way to solve the issue by revert the #9566.
And add it back when the containerd remove the registry.mirror finnaly.

I'm not sure which solution is better:

1. use the new host.toml and fix the bugs, with this PR.
2. use the old registry.mirror, revert the add containerd config_path #9566 .

We can choose one :-)
Would you please comment it.

/hold

[yankay]

HI @oomichi @floryut @cristicalin , would you please review the PR :-)

[lengrongfu]

Thanks to @yankay for the fix. I feel that a switch can be added to determine whether to enable config_path. It is disabled by default. It seems that mirrors will not be used for a long time.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yckaolalala]

Hi @yankay

I opened a PR to fix mirrors in config_path .

[yankay]

Hi @yankay

I opened a PR to fix mirrors in config_path .

Thanks @yckaolalala

I will review the PR.