Use var etcd_deployment_type instead of etcd_kubeadm_enabled #9823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
cncf-cla: yes
liupeng0518
changed the title
floryut
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
@liupeng0518 Thank you, I would have maybe prefer to keep the online style as in this project all roles are include like that but well that's not a nogo for me on this PR 👍
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, liupeng0518 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Nice catch! /lgtm |
k8s-ci-robot
added
the
lgtm
HoKim98
pushed a commit
to ulagbulag/kubespray
that referenced
this pull request
Mar 8, 2023
HoKim98
pushed a commit
to ulagbulag/kubespray
that referenced
this pull request
Mar 8, 2023
nolimitkun
pushed a commit
to nolimitkun/kubespray
that referenced
this pull request
Mar 19, 2023
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Use var etcd_deployment_type instead of etcd_kubeadm_enabled
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: