Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cilium v1.13.0 #9879

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Cilium v1.13.0 #9879

merged 1 commit into from
Mar 23, 2023

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Mar 11, 2023 •
edited by floryut
Loading

What type of PR is this?

/kind application

What this PR does / why we need it:

https://isovalent.com/blog/post/cilium-release-113/
https://github.com/cilium/cilium/releases/tag/1.13.0

Which issue(s) this PR fixes:

Fixes NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[Cilium] Add and support v1.13.0

@k8s-ci-robot
Copy link
Contributor

@utam0k: The label(s) kind/application cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind application

What this PR does / why we need it:

https://isovalent.com/blog/post/cilium-release-113/
https://github.com/cilium/cilium/releases/tag/1.13.0

Which issue(s) this PR fixes:

Fixes NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Cilium v1.13.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 11, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: utam0k / name: Toru Komatsu (c376cb8)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 11, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @utam0k!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @utam0k. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from bozzo and oomichi March 11, 2023 13:02
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 11, 2023
@yankay
Copy link
Member

yankay commented Mar 14, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2023
floryut
floryut approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utam0k Thank you
Please update README though 😄

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, utam0k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
okaufmann added a commit to okaufmann/kubespray that referenced this pull request Mar 16, 2023
@okaufmann
Cilium v1.13.0 kubernetes-sigs#9879
a0fe8ed
@utam0k
Copy link
Member Author

utam0k commented Mar 17, 2023

@utam0k Thank you Please update README though 😄

@floryut Thanks for your review. I have updated

@wbh1 wbh1 mentioned this pull request Mar 21, 2023
Merged
@oomichi
Copy link
Contributor

oomichi commented Mar 23, 2023

Could you rebase this pull request on the latest master branch?
The merged pull request #9902 has fixes the issue of packet_rockylinux9-cilium.

@utam0k
Cilium v1.13.0
4258a3b 
Signed-off-by: utam0k <k0ma@utam0k.jp>
@utam0k
Copy link
Member Author

utam0k commented Mar 23, 2023

Could you rebase this pull request on the latest master branch? The merged pull request #9902 has fixes the issue of packet_rockylinux9-cilium.

@oomichi Thanks for your advice. I have rebased from the main branch.

@oomichi
Copy link
Contributor

oomichi commented Mar 23, 2023

Could you rebase this pull request on the latest master branch? The merged pull request #9902 has fixes the issue of packet_rockylinux9-cilium.

@oomichi Thanks for your advice. I have rebased from the main branch.

Thank you for your quick response!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3a5f569 into kubernetes-sigs:master Mar 23, 2023
@floryut floryut added the kind/network Network section in the release note label Mar 23, 2023
@yankay yankay mentioned this pull request May 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@utam0k @pedromcpedro
Cilium v1.13.0 (kubernetes-sigs#9879)
7916eff 
Signed-off-by: utam0k <k0ma@utam0k.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@utam0k @k8s-ci-robot @yankay @oomichi @floryut