-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cert manager): Fix cert_manager_trusted_internal_ca manifest #9922
Conversation
Welcome @peschmae! |
Hi @peschmae. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peschmae Thank you for the PR 👍
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix :D
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, MrFreezeex, peschmae The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As described in #9921 the cert manager deployment fails if
cert_manager_trusted_internal_ca
is provided together with the dns policy.What type of PR is this?
/kind bug
What this PR does / why we need it:
This moves the volume and mount, to the top of the conditionals in the cert manager manfiest, to fix the order.
Which issue(s) this PR fixes:
Fixes #9921
Special notes for your reviewer:
Alternatively, it would also be possible to split the
volumeMount
and thevolumes
definitions.Does this PR introduce a user-facing change?: