[GCE] Explicitly set KUBE_GCE_NETWORK #100
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/cc @BenTheElder @spiffxp |
| env = append(env, fmt.Sprintf("KUBE_GCE_INSTANCE_PREFIX=%s", d.instancePrefix)) | ||
|
|
||
| // kube-up and kube-down get this as a default ("default" / "e2e-test-${USER}") | ||
| // but log-dump does not, set it explicitly here for maximum consistency |
There was a problem hiding this comment.
neat. did kubetest do this? are there more of these?
There was a problem hiding this comment.
did kubetest do this ?
I don't think so it just relied on the defaults.
are there more of these?
Hopefully not 😅
| // both KUBETEST2_RUN_ID and PROW_JOB_ID uuids are generated | ||
| // following RFC 4122 https://tools.ietf.org/html/rfc4122 | ||
| // e.g. 09a2565a-7ac6-11eb-a603-2218f636630c | ||
| // extract the first 13 characters (09a2565a-7ac6) as they are the ones that depend on |
There was a problem hiding this comment.
if we're constrained to 13/36 characters, perhaps we should skip the fixed -?
There was a problem hiding this comment.
we also probably don't want purely timestamp bits if we can avoid it, else concurrent runs can conflict ...?
There was a problem hiding this comment.
I mean currently it's a fixed name for all so it's no worse
|
@spiffxp how are we managing ACLs for the build cluster? |
|
Anyway the actual error is because it was already deleted by |
k8s-ci-robot
added
size/L
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes: #99
propagates to
https://github.com/kubernetes/kubernetes/blob/0ced9d2854174778163b791038c0a757103455b6/cluster/gce/config-test.sh#L134
Also use a run specific prefix instead of a static one to easily be able to tie back to a run.
xref: kubernetes/enhancements#2464
Tested locally with