For private clusters, do not use --create-subnetwork if it's multi-project profile #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, chizhg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
chizhg
added a commit
to chizhg/tools
that referenced
this pull request
Mar 22, 2021
istio-testing
pushed a commit
to istio/tools
that referenced
this pull request
Mar 22, 2021
Shuanglu
pushed a commit
to Shuanglu/istio-tools
that referenced
this pull request
Jun 30, 2022
Shuanglu
pushed a commit
to Shuanglu/istio-tools
that referenced
this pull request
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since for shared-vpc - the network topology we use for multi-project profile, the subnetworks will be created before cluster creation, so for private cluster + shared vpc, if we also specify
--create-subnetwork, we will get an error which saysCannot specify both --subnetwork and --create-subnetwork at the same time.This PR updates to the logic to only add
--create-subnetworkif it's single-project profile.