gke deployer supports creating GKE Autopilot clusters #129
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/cc @amwat |
kubetest2-gke/deployer/up.go
Outdated
| // A few args are not supported in GKE Autopilot cluster creation, so they should be left unset | ||
| // when they are not provided via the flags. | ||
| // https://cloud.google.com/sdk/gcloud/reference/container/clusters/create-auto | ||
| if d.machineType != "" { | ||
| args = append(args, "--machine-type="+d.machineType) | ||
| } | ||
| if d.nodes != 0 { | ||
| args = append(args, "--num-nodes="+strconv.Itoa(d.nodes)) | ||
| } | ||
| if d.imageType != "" { | ||
| args = append(args, "--image-type="+d.imageType) | ||
| } | ||
|
|
There was a problem hiding this comment.
IIUC the current changes only fixes assumptions while generating the flags , but users still need to use the power "create-command" override?
I think we should just simply support autopilot first class, by adding an auto pilot option?
kubetest2 gke --up --autopilot
and move this validation/generation to verifyUpFlags()
There was a problem hiding this comment.
I considered about this option before making the change. The question is how we should handle the case when the user provides both --autopilot and --create-command=container clusters create xxx yyy flags. If we throw an error, that is even worse than simply relying on "create-command" override. If we replace create with create-auto, that could confuse users..
I think the best way to support this is breaking down --create-command into three flags:
--gcloud-command-version: can be alpha, beta, or default
--autopilot: can be true or false
--gcloud-extra-flags: can be a string of extra flags we want to add to the gcloud command
But since kubetest2 is not versioned now, we'll probably need to consider backward compatibility when we make the change.
WDYT? Any better suggestions?
There was a problem hiding this comment.
Overall I'd want to see a state where if create-command is specified everything else should be ignored (well super ideally this doesn't need to exist, but it's almost impossible to cover all cases so we keep it for power users) .
Relying on a mix of both cluster creation flags of the kubetest2 tool and the custom create command definitely is not great.
--gcloud-command-version: can be alpha, beta, or default
--autopilot: can be true or false
--gcloud-extra-flags: can be a string of extra flags we want to add to the gcloud command
This approach sounds reasonable to me. I don't think we need to worry about backwards compatibility for new flags? (we'll still keep the create-command flag around)
There was a problem hiding this comment.
They need to be mutual exclusive since --create-command can be configured to include all the 3 new flags, so I added a logic to ignore --create-command if any of these 3 new flags are explicitly specified. Please let me know if it looks good to you.
There was a problem hiding this comment.
can we invert it? let's treat --create-command as an explicit override and ignore anything else, and can update the flag help text accordingly.
chizhg
force-pushed
the
gke-autopilot
branch
4 times, most recently
from
753d043
to
3f97d4c
Compare
| args = append(args, "--machine-type="+d.machineType) | ||
| args = append(args, "--num-nodes="+strconv.Itoa(d.nodes)) | ||
| args = append(args, "--image-type="+d.imageType) | ||
| } |
There was a problem hiding this comment.
It might be worth refactoring all the argument builder logic somewhere as a follow up.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, chizhg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
gke deployer supports creating GKE Autopilot clusters.
GKE Autopilot creation command only supports a subset of args of the general cluster creation command, see https://cloud.google.com/sdk/gcloud/reference/container/clusters/create-auto.