Fixes to subnets creation for GKE multiproject profile. #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chizhg
commented
May 10, 2021
chizhg
commented
- subnet create command does not support --zone(https://cloud.google.com/sdk/gcloud/reference/compute/networks/subnets/create) but cluster create command supports, this PR converts zone to region when creating subnets if zonal clusters are requested.
- Move createSubnets and deleteSubnets to separate functions.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
FYI @joshua-bone |
|
/assign @amwat |
amwat
reviewed
May 11, 2021
kubetest2-gke/deployer/deployer.go
Outdated
| @@ -201,14 +202,24 @@ func (d *deployer) verifyLocationFlags() error { | |||
| return nil | |||
| } | |||
|
|
|||
| // location returns the location flags for gcloud commands. | |||
| func location(region, zone string) string { | |||
| // locationFlag returns the location flag for gcloud commands. | |||
There was a problem hiding this comment.
Suggested change
| // locationFlag returns the location flag for gcloud commands. | |
| // locationFlag builds the zone/region flag from the provided zone/region | |
| // prioritizes zones if both are specified | |
| // used by gcloud commands. |
There was a problem hiding this comment.
We actually do not allow --region and --zone to be both set in the verifyLocationFlags function, so I added the comment as:
// locationFlag builds the zone/region flag from the provided zone/region
// used by gcloud commands.
There was a problem hiding this comment.
We actually do not allow --region and --zone to be both set in the verifyLocationFlags function
ACK, mainly the "prioritizes" comment was to highlight what gets chosen if both are specified in context of just this function.
k8s-ci-robot
added
the
approved
1. subnet create command does not support --zone(https://cloud.google.com/sdk/gcloud/reference/compute/networks/subnets/create) but cluster create command supports, this PR converts zone to region when creating subnets if zonal clusters are requested. 2. Move createSubnets and deleteSubnets to separate functions.
k8s-ci-robot
added
size/L
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, chizhg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.