Fix two bugs for kubetest2 gke retry #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
chizhg
changed the title
BenTheElder
approved these changes
Jun 28, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, chizhg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
BenTheElder
reviewed
Jun 28, 2021
| @@ -140,7 +140,7 @@ func runWithOutputAndReturn(cmd exec.Cmd) (string, error) { | |||
|
|
|||
| exec.SetOutput(cmd, io.MultiWriter(os.Stdout, &buf), io.MultiWriter(os.Stderr, &buf)) | |||
| if err := cmd.Run(); err != nil { | |||
| return "", err | |||
There was a problem hiding this comment.
FWIW this is possible to unit test because of our exec shim, I don't want to block fixing this feature, but it might be worth adding a quick set of tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcloudoutput if the cluster creation command fails. This will be used for matching the retryable error pattern to determine whether to retry or not.I have manually tested the change and everything works.
/cc @amwat @BenTheElder