Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script for running e2e tests for kubetest2 gke deployer #156

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

chizhg
Copy link
Contributor

@chizhg chizhg commented Jul 19, 2021

Also BTW fix one issue for kubetest2 gke retry when manually testing the script.

Fixes #152

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 19, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 19, 2021
Copy link
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

kubetest2-gke/ci-tests/buildupdown.sh Show resolved Hide resolved
kubetest2-gke/ci-tests/buildupdown.sh Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2021
@amwat
Copy link
Contributor

amwat commented Jul 19, 2021

let's merge the prow job first so that this get exercised

@chizhg
Copy link
Contributor Author

chizhg commented Jul 19, 2021

This PR should be ready to be merged.

@amwat
Copy link
Contributor

amwat commented Jul 19, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, chizhg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bffdb7d into kubernetes-sigs:master Jul 19, 2021
@chizhg chizhg deleted the kubetest2-gke-e2e-test branch July 19, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E2E tests for kubetest2 gke deployer
3 participants