Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added flags needed for pull-kubernetes-node-e2e job #166

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Added flags needed for pull-kubernetes-node-e2e job #166

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
613ae3d
added required flags
Namanl2001 Sep 21, 2021
11aa625
small nits
Namanl2001 Sep 21, 2021
15df49c
indentation correction
Namanl2001 Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/testers/node/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"flag"
"fmt"
"os"
"strconv"
"time"

"github.com/octago/sflags/gen/gpflag"
Expand Down Expand Up @@ -53,6 +54,8 @@ type Tester struct {
BoskosAcquireTimeoutSeconds int `desc:"How long (in seconds) to hang on a request to Boskos to acquire a resource before erroring."`
BoskosHeartbeatIntervalSeconds int `desc:"How often (in seconds) to send a heartbeat to Boskos to hold the acquired resource. 0 means no heartbeat."`
BoskosLocation string `desc:"If set, manually specifies the location of the boskos server. If unset and boskos is needed"`
ImageConfigFile string `desc:"Path to a file containing image configuration."`
Parallelism int `desc:"The number of nodes to run in parallel."`

// boskos struct field will be non-nil when the deployer is
// using boskos to acquire a GCP project
Expand All @@ -69,6 +72,7 @@ func NewDefaultTester() *Tester {
Runtime: "docker",
BoskosLocation: "http://boskos.test-pods.svc.cluster.local.",
BoskosAcquireTimeoutSeconds: 5 * 60,
Parallelism: 8,
}
}

Expand Down Expand Up @@ -164,6 +168,9 @@ func (t *Tester) constructArgs() []string {
"CLOUDSDK_CORE_PROJECT=" + t.GCPProject,
// https://github.com/kubernetes/kubernetes/blob/96be00df69390ed41b8ec22facc43bcbb9c88aae/hack/make-rules/test-e2e-node.sh#L113
"ZONE=" + t.GCPZone,
"TEST_ARGS=" + t.TestArgs,
"PARALLELISM=" + strconv.Itoa(t.Parallelism),
"IMAGE_CONFIG_FILE=" + t.ImageConfigFile,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do we want to check if it's non-empty?

}
return append(defaultArgs, argsFromFlags...)
}
Expand Down