-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gke: Remove hardcoded default machine types #174
gke: Remove hardcoded default machine types #174
Conversation
Remove hardcoded machine types and instead rely on the server side defaults. Only pass machineType flag if machine type is explicitly provided.
Hi @bobbypage. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Followup on @SergeyKanzhelev comment here - #171 (review) |
/assign @amwat |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the follow up!
/approve Thank you! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, bobbypage, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Remove hardcoded machine types and instead rely on the server side
defaults. Only pass machineType flag if machine type is explicitly
provided.