Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port repo to gimme #24

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Conversation

BenTheElder
Copy link
Member

fixes #23

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2020
@k8s-ci-robot k8s-ci-robot requested review from amwat and cofyc August 7, 2020 02:14
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 7, 2020
@BenTheElder
Copy link
Member Author

/test lol
[now prow will tell me the jobs]

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test gce-build-up-down
  • /test pull-kubetest2-verify
  • /test pull-kubetest2-build

Use /test all to run the following jobs:

  • pull-kubetest2-verify
  • pull-kubetest2-build

In response to this:

/test lol
[now prow will tell me the jobs]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member Author

/test gce-build-up-down

@BenTheElder
Copy link
Member Author

I checked some of the make targets locally, not sure if I missed anything.

Copy link
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Nice, thanks for adding this. This makes builds much easier.
make tidy was the only different one, and I checked it's seems to be working fine.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5961cdc into kubernetes-sigs:master Aug 7, 2020
@BenTheElder BenTheElder deleted the gimme-go branch August 7, 2020 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port this repo to gimme
3 participants