GCE deployer creates firewall rule allowing nodeport access #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
This issue was overlooked for a while because testing of just the deployer works fine without these firewall rules. However, once real testing began, large groups of (unexpected) failures were noticed, especially with the entire NodePort category of tests. Adding these firewall rules (which are present in the old test-setup bash function this deployer replaces) resolves this issue.
michaelmdresser
force-pushed
the
gce-nodeport-firewall
branch
from
d22f6e4
to
afc2ac0
Compare
amwat
reviewed
Aug 12, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, michaelmdresser The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
This brings the failures down to just 3: https://testgrid.k8s.io/provider-gcp-periodics#Conformance%20-%20Cloud%20Provider%20GCP%20-%20master |
|
Awesome! Great work!
…On Thu, Aug 13, 2020 at 7:01 PM Amit Watve ***@***.***> wrote:
FYI @cheftako <https://github.com/cheftako> @cici37
<https://github.com/cici37>
This brings the failures down to just 3:
https://testgrid.k8s.io/provider-gcp-periodics#Conformance%20-%20Cloud%20Provider%20GCP%20-%20master
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHHOA7TLKZL7NIG67XNHHDSASLI3ANCNFSM4P5HWJYA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was overlooked for a while because testing of just the deployer works fine without these firewall rules. However, once real testing began, large groups of (unexpected) failures were noticed (see https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/92316/pull-kubernetes-e2e-gce-kubetest2/1293334635354263552), especially with the entire NodePort category of tests. Adding these firewall rules (which are present in the old test-setup bash function this deployer replaces) resolves this issue.
Tested locally. Firewalls are correctly created and deleted. Previously failing NodePort tests pass.