Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RawCommand and RawCommandContext functions #37

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Add RawCommand and RawCommandContext functions #37

merged 1 commit into from
Aug 13, 2020

Conversation

chizhg
Copy link
Contributor

@chizhg chizhg commented Aug 13, 2020

As discussed offline, add RawCommand and RawCommandContext functions which can run more the commands in a more native way. Also use it to run some simple commands for kubetest2 gke deployer. I did some regression tests on my local and nothing breaks.

/cc @amwat

@k8s-ci-robot k8s-ci-robot requested a review from amwat August 13, 2020 05:43
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 13, 2020
amwat
amwat reviewed Aug 13, 2020
View reviewed changes
Copy link
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, chizhg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit f1a9c41 into kubernetes-sigs:master Aug 13, 2020
@chizhg chizhg deleted the add-raw-command branch June 14, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amwat amwat amwat left review comments

Assignees

@amwat amwat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chizhg @k8s-ci-robot @amwat