[GKE deployer] Enable building from source #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
amwat
force-pushed
the
build-source
branch
3 times, most recently
from
2bc3fc2 to
b24766a
Compare
BenTheElder
reviewed
Sep 15, 2020
| type BuildOptions struct { | ||
| Strategy string `flag:"~strategy" desc:"Determines the build strategy to use either make or bazel."` | ||
| StageLocation string `flag:"~stage" desc:"Upload binaries to gs://bucket/ci/job-suffix if set"` | ||
| Version string `flag:"~version" desc:"Use a specific GKE version e.g. 1.16.13.gke-400 or 'latest' or 'source' which will build kubernetes from source."` |
There was a problem hiding this comment.
I feel like --build should imply --version=source ...?
|
this seems like a solid starting point |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add build options to control building kubernetes from source.
Refactor and extract out common functionality to pkg/
Start consolidating flags into individual options.
/cc @BenTheElder