Log the commands before running them for easier debugging #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
amwat
reviewed
Jan 19, 2021
| return &LocalCmd{ | ||
| Cmd: osexec.Command(name, arg...), | ||
| } | ||
| } | ||
|
|
||
| // CommandContext returns a new exec.Cmd with the context, backed by Cmd | ||
| func (c *LocalCmder) CommandContext(ctx context.Context, name string, arg ...string) Cmd { | ||
| klog.V(2).Infof("⚙️ %s %s", name, strings.Join(arg, " ")) |
There was a problem hiding this comment.
This might cause issues rendering in some terminals, but we can add handling for TERM=dumb later if we run into any issues.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, chizhg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we want to debug issues related to
kubetest2but it's pretty hard to dig out the commands that were run during the process. This PR will log the commands before running them for easier debugging.