Skip to content

Commit

Permalink
Final remarks
Browse files Browse the repository at this point in the history
Change-Id: I33499a6b3241c0f01e672e5f37db224788d95265
  • Loading branch information
alculquicondor committed Nov 17, 2022
1 parent e6dc378 commit 16e500c
Showing 1 changed file with 24 additions and 5 deletions.
29 changes: 24 additions & 5 deletions keps/83-workload-preemption/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
- [Prerequisite testing updates](#prerequisite-testing-updates)
- [Unit Tests](#unit-tests)
- [Integration tests](#integration-tests)
- [E2E tests](#e2e-tests)
- [Graduation Criteria](#graduation-criteria)
- [Implementation History](#implementation-history)
- [Drawbacks](#drawbacks)
Expand Down Expand Up @@ -396,10 +397,7 @@ to implement this enhancement.

##### Prerequisite testing updates

<!--
Based on reviewers feedback describe what additional tests need to be added prior
implementing this enhancement to ensure the enhancements have also solid foundations.
-->
- Need to improve coverage of `pkg/queue` up to at least 80%.

#### Unit Tests

Expand All @@ -420,10 +418,23 @@ This can inform certain test coverage improvements that we want to do before
extending the production code to implement this enhancement.
-->

- `<package>`: `<date>` - `<test coverage>`
- `apis/kueue/webhooks`: `2022-11-17` - `72%`
- `pkg/cache`: `2022-11-17` - `83%`
- `pkg/scheduler`: `2022-11-17` - `91%`
- `pkg/queue`: `2022-11-17` - `62%`

#### Integration tests

- No new workloads in the cohort can borrow when workloads in a ClusterQueue
fit whitin their min quota (StrictFIFO and BestEffortFIFO), but there are
running workloads.
- Preemption within a ClusterQueue based on priority.
- Preemption within a Cohort to satisfy min quota.

#### E2E tests

- Preemption within a ClusterQueue based on priority.

<!--
Describe what tests will be added to ensure proper quality of the enhancement.

Expand All @@ -448,6 +459,8 @@ milestones with these graduation criteria:
[deprecation-policy]: https://kubernetes.io/docs/reference/using-api/deprecation-policy/
-->

N/A

## Implementation History

<!--
Expand All @@ -461,12 +474,18 @@ Major milestones might include:
- when the KEP was retired or superseded
-->

1. 2022-09-19: First draft, included multiple knobs.
2. 2022-11-17: Complete proposal with minimal API.

## Drawbacks

<!--
Why should this KEP _not_ be implemented?
-->

Preemption is costly to calculate. However, it's a highly demanded feature.
The API allows preemption to be opt-in.

## Alternatives

The following APIs were initially proposed to enhance the control over
Expand Down

0 comments on commit 16e500c

Please sign in to comment.