Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mimowo committed Nov 21, 2023
1 parent cde3c0e commit 2db7353
Showing 1 changed file with 1 addition and 23 deletions.
24 changes: 1 addition & 23 deletions keps/1136-provisioning-request-support/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,7 @@ OwnerReference).

* Retry ProvisioningRequests with respect to the `RetryConfig` configuration in
the `ProvisioningRequestConfig`. For each attempt a new provisioning request is
created with the suffix indicating the attempt number. The attempt number will
also be kept in ProvisioningRequest annotation:
`kueue.x-k8s.io/provisioning-request-attempt`. The corresponding admission
created with the suffix indicating the attempt number. The corresponding admission
check will remain in the `Pending` state until the retries end.

The definition of `ProvisioningRequestConfig` is relatively simple and is based on
Expand Down Expand Up @@ -153,26 +151,6 @@ type ProvisioningRequestConfigSpec struct {
// +listType=set
// +kubebuilder:validation:MaxItems=100
ManagedResources []corev1.ResourceName `json:"managedResources,omitempty"`

// RetryConfig defines the retry configuration for a provisioning request
//
// +optional
RetryConfig *ProvisioningRequestRetryConfig `json:"retryConfig,omitempty"`
}

// ProvisioningRequestRetryConfig defines the retry configuration for the provisioning requests
type ProvisioningRequestRetryConfig struct {
// MaxRetries indicates the maximal number of retries for recreating the provisioning request.
//
// +optional
// +kubebuilder:default=3
MaxRetries *int32 `json:"maxRetries,omitempty"`

// DefaultBackoffSeconds indicates the default backoff in seconds. The intervals
// between consecutive attempts are determined by expotential growth up to 30min.
// +optional
// +kubebuilder:default=60
DefaultBackoffSeconds *int32 `json:"minBackoffSeconds,omitempty"`
}
```

Expand Down

0 comments on commit 2db7353

Please sign in to comment.