Skip to content

Commit

Permalink
Improve links (#1672)
Browse files Browse the repository at this point in the history
  • Loading branch information
PBundyra authored Jan 30, 2024
1 parent b7fc93f commit 38cedb1
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions keps/1136-provisioning-request-support/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@

## Summary

Introduce an (AdmissionCheck)[https://github.com/kubernetes-sigs/kueue/tree/main/keps/993-two-phase-admission]
that will use (`ProvisioningRequest`)[https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/proposals/provisioning-request.md]
Introduce an [AdmissionCheck](https://github.com/kubernetes-sigs/kueue/tree/main/keps/993-two-phase-admission)
that will use [`ProvisioningRequest`](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/proposals/provisioning-request.md)
to ensure that there is enough capacity in the cluster before
admitting a workload.

Expand All @@ -33,7 +33,7 @@ Currently Kueue admits workloads based on the quota check alone.
This works reasonably well in most cases, but doesn't provide
guarantee that an admitted workload will actually schedule
in full in the cluster. With `ProvisioningRequest`, SIG-Autoscaling owned
(ClusterAutoscaler)[https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler]
[ClusterAutoscaler](https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler)
opens a way for stronger (but still not hard-guaranteed) all-or-nothing
scheduling in an autoscaled cloud environment.

Expand Down Expand Up @@ -74,7 +74,7 @@ succeeds.
### Risks and Mitigations

There doesn't seem to be much risks or mitigations.
(Two phase admission process)[https://github.com/kubernetes-sigs/kueue/tree/main/keps/993-two-phase-admission]
[Two phase admission process](https://github.com/kubernetes-sigs/kueue/tree/main/keps/993-two-phase-admission)
was added specifically for use cases like this.

## Design Details
Expand All @@ -98,7 +98,7 @@ will also need to watch `ProvisioningRequestConfigs`.
* Watch all changes CA makes to `ProvisioningRequests`. If the `Provisioned`
or `CapacityAvailable` condition is set to `True` then finish the `AdmissionCheck`
with success (and propagate the information about `ProvisioningRequest` name to
workload pods - KEP #1145 under `"cluster-autoscaler.kubernetes.io/consume-provisioning-request"`.
workload pods - [KEP #1145](https://github.com/kubernetes-sigs/kueue/blob/main/keps/1145-additional-labels/kep.yaml) under `"cluster-autoscaler.kubernetes.io/consume-provisioning-request"`.
If the `ProvisioningRequest` fails, fail the `AdmissionCheck`.

* Watch the admission of the workload - if it is again suspended or finished,
Expand Down

0 comments on commit 38cedb1

Please sign in to comment.