Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] add documentation for workloadPriorityClass #1157

Closed
1 task
Gekko0114 opened this issue Sep 24, 2023 · 16 comments · Fixed by #1170
Closed
1 task

[doc] add documentation for workloadPriorityClass #1157

Gekko0114 opened this issue Sep 24, 2023 · 16 comments · Fixed by #1170
Assignees
Labels
kind/documentation Categorizes issue or PR as related to documentation. needs-kind Indicates a PR lacks a `kind/foo` label and requires one.

Comments

@Gekko0114
Copy link
Member

Gekko0114 commented Sep 24, 2023

What would you like to be added:
documentation for workloadPriorityClass

Why is this needed:
to support users

Completion requirements:
add documentation under site repo.

This enhancement requires the following artifacts:

  • Docs update

Related to this PR #1081

@Gekko0114 Gekko0114 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 24, 2023
@Gekko0114
Copy link
Member Author

Gekko0114 commented Sep 24, 2023

/remove-kind feature

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Sep 24, 2023
@Gekko0114
Copy link
Member Author

/assign

BTW, I can't add label on this issue. Could anyone add "kind/documentation" label?

@tenzen-y
Copy link
Member

/documentation

@tenzen-y
Copy link
Member

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 25, 2023
@tenzen-y
Copy link
Member

/remove-label needs-kind

@k8s-ci-robot
Copy link
Contributor

@tenzen-y: The label(s) /remove-label needs-kind cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label needs-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tenzen-y
Copy link
Member

/needs-kind cancel

@alculquicondor
Copy link
Contributor

/remove-kind documentation

@k8s-ci-robot k8s-ci-robot removed the kind/documentation Categorizes issue or PR as related to documentation. label Sep 27, 2023
@alculquicondor
Copy link
Contributor

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 27, 2023
@alculquicondor
Copy link
Contributor

No idea what's happening. Can you create a new PR?

@Gekko0114
Copy link
Member Author

No idea what's happening. Can you create a new PR?

I will create a PR explaining how to use workloadPriority in https://kueue.sigs.k8s.io/docs/
Does it make sense?

@alculquicondor
Copy link
Contributor

oops, I thought for a second this was a PR, not an issue. In that case, it doesn't matter much that this has the needs-kind label.

@Gekko0114
Copy link
Member Author

Hi @alculquicondor , @tenzen-y

BTW, I would like to become a member of k8s/k8s-sig. Could you be willing to sponsor me?
(This is completely unrelated to this issue, I apologize.)

@tenzen-y
Copy link
Member

tenzen-y commented Oct 2, 2023

Hi @alculquicondor , @tenzen-y

BTW, I would like to become a member of k8s/k8s-sig. Could you be willing to sponsor me? (This is completely unrelated to this issue, I apologize.)

Sure. If you meet the requirements for the member, I'm happy to become a sponsor.

@alculquicondor
Copy link
Contributor

Me too

@Gekko0114
Copy link
Member Author

Thank you so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. needs-kind Indicates a PR lacks a `kind/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants