You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What happened:
While refactoring Preemptor.GetTargets, I encountered a panic. Furthermore, I discovered that we are not exercising the PartialAdmission preemption logic in any of our tests, and it may be broken and panicking generally.
This test exits here, as we find a preemption target above. The PartialAdmission preemption path is not tested.
In this test, we exit here. We panic when calling assignment.TotalRequestsFor, as this map is empty
How to reproduce it (as minimally and precisely as possible):
Move this line to the top of Preemptor.GetTargets and observe a panic during this test
What happened:
While refactoring
Preemptor.GetTargets
, I encountered a panic. Furthermore, I discovered that we are not exercising the PartialAdmission preemption logic in any of our tests, and it may be broken and panicking generally.This test exits here, as we find a preemption target above. The PartialAdmission preemption path is not tested.
In this test, we exit here. We panic when calling
assignment.TotalRequestsFor
, as this map is emptyHow to reproduce it (as minimally and precisely as possible):
Move this line to the top of
Preemptor.GetTargets
and observe a panic during this testkueue/pkg/scheduler/preemption/preemption.go
Line 116 in 00111d9
Delete these lines and observe that unit and integration tests still pass
kueue/pkg/scheduler/scheduler.go
Lines 477 to 481 in 00111d9
The text was updated successfully, but these errors were encountered: