Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella] ☂️ Requirements for release 0.1.0 #63

Closed
10 of 14 tasks
alculquicondor opened this issue Feb 24, 2022 · 35 comments
Closed
10 of 14 tasks

[Umbrella] ☂️ Requirements for release 0.1.0 #63

alculquicondor opened this issue Feb 24, 2022 · 35 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@alculquicondor
Copy link
Contributor

alculquicondor commented Feb 24, 2022

Deadline: May 16th Kubecon EU

Issues that we need to complete to consider kueue ready for a first release:

Nice to have:

@alculquicondor
Copy link
Contributor Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 24, 2022
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Feb 24, 2022
@alculquicondor
Copy link
Contributor Author

cc @ahg-g @ArangoGutierrez @denkensk thoughts? Did I miss something?

@ArangoGutierrez
Copy link
Contributor

Ohhhh that smell of a new release in the air.... uh lala

@denkensk
Copy link
Member

User guide is also needed.

@ArangoGutierrez
Copy link
Contributor

something we can quickly implement as well could be github-pages for small documentation? (I can volunteer have done that for other sigs)

@denkensk
Copy link
Member

#14 Is there any progress on this? @ArangoGutierrez

@ArangoGutierrez
Copy link
Contributor

we agree to wait for klog/v3 no?

But this is changing soon https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3077-contextual-logging

In the meantime, if we stick with logr for now, I think it will be easier to switch to klog (v3?) once it supports contextual logging.

@ArangoGutierrez
Copy link
Contributor

I would add #52 to that checklist

@ahg-g
Copy link
Contributor

ahg-g commented Feb 24, 2022

I don't think we should block the first release on #62, ceiling is workable for a 0.0.1 version .

@ArangoGutierrez
Copy link
Contributor

can we set KubeCon EU as dead line for this? would be a nice thing to achieve

@ahg-g
Copy link
Contributor

ahg-g commented Feb 24, 2022

Yeah, I submitted a proposal to present it at KubeCon the general event, but will also be discussing it in the colo event.

@denkensk
Copy link
Member

Great

@alculquicondor
Copy link
Contributor Author

I think we should be able to have something sooner. But kubecon EU is a nice hard deadline :) Added to the description.

I don't think we should block the first release on #62, ceiling is workable for a 0.0.1 version .

I think it is indeed usable, but migrating to weights from the first version will avoid one breaking change. Sure... they are alpha APIs, but if we can avoid it, it would be great. Moved to nice-to-have.

@ArangoGutierrez
Copy link
Contributor

@alculquicondor can you pin this? so is easier to find

@alculquicondor alculquicondor pinned this issue Mar 1, 2022
@ahg-g
Copy link
Contributor

ahg-g commented Mar 2, 2022

I think we need to add #4 to the list, I will work on that.

@ahg-g
Copy link
Contributor

ahg-g commented Mar 3, 2022

also #91

@ArangoGutierrez
Copy link
Contributor

check mark Publish image https://github.com/kubernetes-sigs/kueue/issues/52

@ArangoGutierrez
Copy link
Contributor

Check Single heap per Capacity https://github.com/kubernetes-sigs/kueue/issues/87

@ArangoGutierrez
Copy link
Contributor

ArangoGutierrez commented Mar 11, 2022

we have an image!!!
gcr.io/k8s-staging-kueue/kueue:devel

[eduardo@fedora-workstation kueue]$ skopeo list-tags docker://gcr.io/k8s-staging-kueue/kueue
{
    "Repository": "gcr.io/k8s-staging-kueue/kueue",
    "Tags": [
        "devel"
    ]
}

Prow job: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kueue-push-images/1502394011774619648

@ArangoGutierrez
Copy link
Contributor

CHeckMark -> Queue status https://github.com/kubernetes-sigs/kueue/issues/5

@ArangoGutierrez
Copy link
Contributor

Checkmark Event for unschedulable workloads #91

@ArangoGutierrez
Copy link
Contributor

checkmark User guide https://github.com/kubernetes-sigs/kueue/issues/64

@alculquicondor alculquicondor changed the title [Umbrella] ☂️ Requirements for release 0.0.1 [Umbrella] ☂️ Release 0.1.0 Apr 8, 2022
@alculquicondor
Copy link
Contributor Author

@ahg-g @denkensk @ArangoGutierrez PTAL at the draft for release notes in the issue description.

@ArangoGutierrez
Copy link
Contributor

@alculquicondor alculquicondor changed the title [Umbrella] ☂️ Release 0.1.0 [Umbrella] ☂️ Requirements for release 0.1.0 Apr 8, 2022
@alculquicondor
Copy link
Contributor Author

Opened #197

@ahg-g
Copy link
Contributor

ahg-g commented Apr 9, 2022

A couple of other renames we should do:

  1. cq.requestableResources -> resources
  2. cq.flavor.resourceFlavor -> cq.flavor.name

@ahg-g
Copy link
Contributor

ahg-g commented Apr 10, 2022

Before the first release we need to ignore jobs with queue name not set; this is important so users are not surprised that their existing running jobs get suspended when they first try Kueue.

We will add a flag to ComponentConfig to disable this behavior, and a namespace selector to select which namespaces the job-controller will take over. We can do that in the next release.

@alculquicondor alculquicondor unpinned this issue Apr 11, 2022
@alculquicondor
Copy link
Contributor Author

sgtm, can you open an issue and/or PR?

@ahg-g
Copy link
Contributor

ahg-g commented Apr 11, 2022

I will address the two comments above once the multiple api groups pr merges

@alculquicondor
Copy link
Contributor Author

alculquicondor commented Apr 11, 2022

A couple of other renames we should do:

  1. cq.requestableResources -> resources
  2. cq.flavor.resourceFlavor -> cq.flavor.name

+1 to both

@ahg-g
Copy link
Contributor

ahg-g commented Apr 11, 2022

#205 disables reconciling jobs with no queue name set.

@ahg-g
Copy link
Contributor

ahg-g commented Apr 11, 2022

and #206 for renaming requestableResources in the api.

@ahg-g
Copy link
Contributor

ahg-g commented Apr 12, 2022

and #207 for component config

@alculquicondor
Copy link
Contributor Author

All items are complete. We probably leave the nice-to-have issues for the next release.

/close

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Closing this issue.

In response to this:

All items are complete. We probably leave the nice-to-have issues for the next release.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants