Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Flaky test: Kueue when Creating a Job With Queueing [It] Should unsuspend a job and set nodeSelectors #1025

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fix Flaky test: Kueue when Creating a Job With Queueing [It] Should unsuspend a job and set nodeSelectors #1025

merged 1 commit into from
Jul 31, 2023

Conversation

BinL233
Copy link
Contributor

@BinL233 BinL233 commented Jul 29, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Create const LongTimeout for e2e test.
Pods in test sometimes takes long time because of the image pulling.

Which issue(s) this PR fixes:

Fixes #1021

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 29, 2023
@netlify
Copy link

netlify bot commented Jul 29, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 023837d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/64c47c60f8749f0007c5706f

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 29, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @BinL233. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 29, 2023
@tenzen-y
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2023
mimowo
mimowo reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
as a follow up (or at some point) we may consider pulling all images before running e2e tests, as in k/k: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/e2e.go#L249-L252

test/e2e/e2e_test.go
@@ -141,7 +141,7 @@ var _ = ginkgo.Describe("Kueue", func() {
return workload.IsAdmitted(createdWorkload) &&
apimeta.IsStatusConditionTrue(createdWorkload.Status.Conditions, kueue.WorkloadFinished)

}, util.Timeout, util.Interval).Should(gomega.BeTrue())
}, util.LongTimeout, util.Interval).Should(gomega.BeTrue())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2023
@alculquicondor
Copy link
Contributor

/approve
+1 on @mimowo's suggestion

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, BinL233

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@alculquicondor
Copy link
Contributor

There is another flaky test: #1027

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3944f33 into kubernetes-sigs:main Jul 31, 2023
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Jul 31, 2023
@alculquicondor
Copy link
Contributor

It looks like it wasn't long enough https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/1014/pull-kueue-test-e2e-main-1-24/1687045071767080960

@mimowo
Copy link
Contributor

mimowo commented Aug 3, 2023

At this point I think it is better to implement pre-pull. I will open an Issue

@BinL233 BinL233 deleted the 1021-final branch August 25, 2023 16:10
@mimowo mimowo mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@denkensk denkensk Awaiting requested review from denkensk

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.

Flaky test: Kueue when Creating a Job With Queueing [It] Should unsuspend a job and set nodeSelectors
5 participants
@BinL233 @k8s-ci-robot @tenzen-y @alculquicondor @mimowo