Support kubeflow.org/tfjob #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @trasc |
|
I can take this one |
| }) | ||
| }) | ||
|
|
||
| var _ = ginkgo.Describe("Job controller for workloads when only jobs with queue are managed", ginkgo.Ordered, ginkgo.ContinueOnFailure, func() { |
There was a problem hiding this comment.
I would remove this test. It can be tested in unit. And it's already tested for other jobs.
There was a problem hiding this comment.
Do other jobs mean kubeflowjobs?
There was a problem hiding this comment.
Other jobs in general. But, I guess we can keep the test for PytorchJob
| util.ExpectAdmittedActiveWorkloadsMetric(clusterQueue, 1) | ||
| }) | ||
|
|
||
| ginkgo.When("The workload's admission is removed", func() { |
There was a problem hiding this comment.
I would also remove this test for similar reasons as above.
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
support-kubeflow-tfjob
branch
from
43e5f28 to
b96cffe
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
@alculquicondor I addressed your comments. PTAL. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
achernevskii
pushed a commit
to epam/kubernetes-kueue
that referenced
this pull request
Sep 7, 2023
* Support kubeflow.org/tfjob Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Adapt tfjob to commonized kubeflowjob Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Remove duplicated integration test cases Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> --------- Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
achernevskii
pushed a commit
to epam/kubernetes-kueue
that referenced
this pull request
Sep 8, 2023
* Support kubeflow.org/tfjob Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Adapt tfjob to commonized kubeflowjob Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Remove duplicated integration test cases Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> --------- Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
I added the tfjob-controller to the frameworkjob-manager.
Which issue(s) this PR fixes:
Part-of #297
Special notes for your reviewer:
Does this PR introduce a user-facing change?