Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preemption admission check controller #1113

Closed
wants to merge 17 commits into from

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Sep 12, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add the possibility to delay the eviction triggering in case of preemption based on the preempting workload admission checks configuration.

Which issue(s) this PR fixes:

Fixes #1677

Special notes for your reviewer:

Some additional test will be added.

Does this PR introduce a user-facing change?

Manage the eviction on preemption based on admission checks.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 12, 2023
@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 371072a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/652785db451b7100086f382e

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 12, 2023
@trasc trasc force-pushed the preemption-check-controller branch 2 times, most recently from 260cce8 to 1465d40 Compare September 12, 2023 18:25
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 12, 2023
@trasc trasc force-pushed the preemption-check-controller branch 3 times, most recently from 5685266 to c2d3d12 Compare September 14, 2023 12:49
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 14, 2023
@trasc
Copy link
Contributor Author

trasc commented Sep 15, 2023

/test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 15, 2023
@trasc trasc changed the title Preemption check controller Preemption admission check controller Sep 15, 2023
@trasc trasc marked this pull request as ready for review September 15, 2023 12:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 15, 2023
@trasc trasc force-pushed the preemption-check-controller branch from 09146eb to bd5bdbe Compare October 4, 2023 08:28
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2023
@trasc trasc force-pushed the preemption-check-controller branch from bd5bdbe to 68c14f4 Compare October 4, 2023 09:23
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2023
@trasc trasc force-pushed the preemption-check-controller branch from ce7e628 to 415867d Compare October 10, 2023 12:42
@trasc trasc force-pushed the preemption-check-controller branch from 415867d to 9a116d3 Compare October 11, 2023 06:11
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@trasc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-e2e-main-1-29 371072a link true /test pull-kueue-test-e2e-main-1-29
pull-kueue-test-multikueue-e2e-main-1-29 371072a link true /test pull-kueue-test-multikueue-e2e-main-1-29
pull-kueue-test-scheduling-perf-main 371072a link true /test pull-kueue-test-scheduling-perf-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alculquicondor
Copy link
Contributor

Let's close this for now.

Given all the work we are doing to implement fair sharing preemption, it's not a good time to put this in place.

/close

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Closed this PR.

In response to this:

Let's close this for now.

Given all the work we are doing to implement fair sharing preemption, it's not a good time to put this in place.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to defer preemption when using admission checks
6 participants