Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update webhook template for pod integration #1247

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Update webhook template for pod integration #1247

merged 1 commit into from
Oct 25, 2023

Conversation

achernevskii
Copy link
Contributor

@achernevskii achernevskii commented Oct 24, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Now helm will use namespace selector from the kueue configuration for the pod webhook.

  • If no namespace selector is set in the configuration, default selector will be used.

  • If pod integration is disabled, pod related webhooks will have failurePolicy set to Ignore.

Which issue(s) this PR fixes:

Related issue: #976

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@achernevskii
Update webhook template for pod integration
08d84a0 
* Now helm will use namespace selector from the
  kueue configuration for the pod webhook.

* If no namespace selector is set in the
  configuration, default selector will be used.

* If pod integration is disabled, pod related
  webhooks will have failurePolicy set to Ignore.
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 24, 2023
@netlify
Copy link

netlify bot commented Oct 24, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 08d84a0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6537a6f3fcee76000855ff58
😎 Deploy Preview https://deploy-preview-1247--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @achernevskii. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 24, 2023
@alculquicondor
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2023
@alculquicondor
Copy link
Contributor

/lgtm
/approve

It looks like we don't keep the charts/kueue/templates/webhook folder automatically updated when we add a new CRD, do we?

I guess it might need to stay that way, otherwise it would be hard to do replacements like this.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achernevskii, alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8f0fe37607b7f0d811b56d31acd2550c02a8c1e8

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@achernevskii
Copy link
Contributor Author

It looks like we don't keep the charts/kueue/templates/webhook folder automatically updated when we add a new CRD, do we?

Yes. Only files in charts/kueue/templates/crd and charts/kueue/templates/rbac are updated by the make update-helm target.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8bfc870 into kubernetes-sigs:main Oct 25, 2023
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Oct 25, 2023
@achernevskii achernevskii mentioned this pull request Oct 26, 2023
Closed
9 tasks
@achernevskii achernevskii deleted the feature/helm_pod_integration branch October 27, 2023 13:32
@B1F030 B1F030 mentioned this pull request Nov 8, 2023
Closed
@trasc trasc mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@achernevskii @k8s-ci-robot @alculquicondor