Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kind to 0.20.0 #1504

Merged
merged 2 commits into from
Jan 16, 2024
Merged

update kind to 0.20.0 #1504

merged 2 commits into from
Jan 16, 2024

Conversation

kannon92
Copy link
Contributor

What type of PR is this?

/kind cleanup
/kind testing

What this PR does / why we need it:

Update Kind to 0.20.0 so we can pick up 1.29.0 images.

Drop deprecated kubernetes versions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I am noticing something odd in Kind 0.20.0 around cert rotation so I think we should test the CI pretty well here once 1.29 test-infra PR merges.

See kubernetes-sigs/jobset#357 for some discussion on this.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 21, 2023
@k8s-ci-robot
Copy link
Contributor

@kannon92: The label(s) kind/testing cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind cleanup
/kind testing

What this PR does / why we need it:

Update Kind to 0.20.0 so we can pick up 1.29.0 images.

Drop deprecated kubernetes versions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I am noticing something odd in Kind 0.20.0 around cert rotation so I think we should test the CI pretty well here once 1.29 test-infra PR merges.

See kubernetes-sigs/jobset#357 for some discussion on this.

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 21, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 21, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 9bda9ab
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65a59f781c4bd600088f29ff

@kannon92
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2023
@kannon92
Copy link
Contributor Author

/test pull-kueue-test-e2e-main-1-28

tenzen-y
tenzen-y reviewed Dec 21, 2023
View reviewed changes
Makefile Outdated
@@ -65,7 +65,7 @@ E2E_TARGET ?= ./test/e2e/...
E2E_KIND_VERSION ?= kindest/node:v1.28.0

# E2E_K8S_VERSIONS sets the list of k8s versions included in test-e2e-all
E2E_K8S_VERSIONS ?= 1.24.15 1.25.11 1.26.6 1.27.3 1.28.0
E2E_K8S_VERSIONS ?= 1.26.6 1.27.3 1.28.0 1.29.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kannon92 Can we update the Kubernetes version in other places like ENVTEST_K8S_VERSION?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its at 1.28.0 and I don't know if we should update that to 1.29.0 yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use the latest patch version for 1.28

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. sorry for the lag.

@kannon92
Copy link
Contributor Author

/test pull-kueue-test-e2e-main-1-28
/test pull-kueue-test-e2e-main-1-29

@kannon92
Copy link
Contributor Author

@tenzen-y @alculquicondor I got a bit confused by kind's website. I was thinking that the latest versions of Kind would have 1.29 but it seems that 0.18.0 has it also.

Do you all still an update to the latest version of kind?

@tenzen-y
Copy link
Member

@tenzen-y @alculquicondor I got a bit confused by kind's website. I was thinking that the latest versions of Kind would have 1.29 but it seems that 0.18.0 has it also.

Do you all still an update to the latest version of kind?

@kannon92 I see. Then, can we update only the KinD version in this PR?

@kannon92
Copy link
Contributor Author

@tenzen-y @alculquicondor I got a bit confused by kind's website. I was thinking that the latest versions of Kind would have 1.29 but it seems that 0.18.0 has it also.
Do you all still an update to the latest version of kind?

@kannon92 I see. Then, can we update only the KinD version in this PR?

@alculquicondor and @tenzen-y I pushed a change for this and updated all the kind versions to be the latest kind and updated the version. It probably makes sense for kind image to be the latest patch.

tenzen-y
tenzen-y reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/apprvoe

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4f146d2b2c4374bcf0c914e8b5d9e42496b3c3e2

@tenzen-y
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
@tenzen-y
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 890d121 into kubernetes-sigs:main Jan 16, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Jan 16, 2024
kannon92 added a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@kannon92
update kind to 0.20.0 (kubernetes-sigs#1504)
78a9221 
* update kind to 1.29.0

* update patch version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@denkensk denkensk Awaiting requested review from denkensk

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@kannon92 @k8s-ci-robot @tenzen-y @alculquicondor