Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-79: Hierarchical Cohorts #1531

Merged
merged 1 commit into from
Feb 9, 2024
Merged

KEP-79: Hierarchical Cohorts #1531

merged 1 commit into from
Feb 9, 2024

Conversation

mwielgus
Copy link
Contributor

@mwielgus mwielgus commented Dec 29, 2023 •
edited by alculquicondor
Loading

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Introduces a hierarchy among Cohorts via a new API object.

Which issue(s) this PR fixes:

Part of #79

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Dec 29, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 29, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 29, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit cc462ad
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65c647017c856c000808f180

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 29, 2023
@alculquicondor
Copy link
Contributor

/cc

@alculquicondor
Copy link
Contributor

cc @KunWuLuan

@mwielgus mwielgus force-pushed the kep-hc branch 2 times, most recently from 3487efd to 84afbdd Compare January 2, 2024 15:18
mimowo
mimowo reviewed Jan 3, 2024
View reviewed changes
keps/79-hierarchical-cohorts/README.md Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/kep.yaml Show resolved Hide resolved
@mwielgus mwielgus force-pushed the kep-hc branch 2 times, most recently from 9e44bab to 96d3895 Compare January 3, 2024 14:58
alculquicondor
alculquicondor reviewed Jan 3, 2024
View reviewed changes
keps/79-hierarchical-cohorts/README.md Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md
// from ClusterQueues/Cohorts that are NOT under this Cohort. For Cohorts without
// a parent(top of the hierarchy) the BorrowingLimit has to be 0.
//
// LendingLimit specifies how much ClusterQueues that are NOT under this Cohort
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @kerthcet

keps/79-hierarchical-cohorts/README.md Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Show resolved Hide resolved
tenzen-y
tenzen-y reviewed Jan 4, 2024
View reviewed changes
keps/79-hierarchical-cohorts/README.md Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Outdated Show resolved Hide resolved
@zmlcc
Copy link

zmlcc commented Jan 8, 2024

What's the relationship between this kep and #1093 ? Hierarchical Cohorts or Hierarchical ClusterQueue is better ？

@mwielgus
Copy link
Contributor Author

mwielgus commented Jan 8, 2024

@zmlcc This KEP is heavily influenced by #1093, and tries to address the problems of Hierarchical ClusterQueues like:

  • 2 flavors of hierarchy - ClusterQueue parent-child relation and Cohort membership.
  • a bit ambiguous semantics.

I think that with Hierarchical Cohorts we don't have these problems and it should be our way forward. But I'm more than open to discussion and hearing arguments agains it.

alculquicondor
alculquicondor reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this as provisional.

keps/79-hierarchical-cohorts/kep.yaml Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/kep.yaml Show resolved Hide resolved
keps/79-hierarchical-cohorts/kep.yaml Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/kep.yaml Outdated Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Show resolved Hide resolved
keps/79-hierarchical-cohorts/README.md Show resolved Hide resolved
@alculquicondor
Copy link
Contributor

Merging this as provisional.

We can have follow ups as we start preparing for the 0.7 release.

@alculquicondor
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8b3b24a9acf78045bb2ba583c20cd87bc4f16f32

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@alculquicondor alculquicondor mentioned this pull request Feb 9, 2024
Closed
@k8s-ci-robot k8s-ci-robot merged commit 209c096 into kubernetes-sigs:main Feb 9, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Feb 9, 2024
@mwielgus mwielgus mentioned this pull request Mar 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@mimowo mimowo mimowo left review comments

@KunWuLuan KunWuLuan KunWuLuan left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.
7 participants
@mwielgus @alculquicondor @zmlcc @k8s-ci-robot @mimowo @KunWuLuan @tenzen-y