Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add printer columns to Queue, ClusterQueue and QueuedWorkload #156

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

alculquicondor
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds printer columns to all the resources for a quick overview of the resources

Which issue(s) this PR fixes:

Part of #86

Special notes for your reviewer:

Change-Id: I294d6eebfdc714ab70631820d50e7f676b53dc43
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 28, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2022
@alculquicondor
Copy link
Contributor Author

/assign @ahg-g

@ahg-g
Copy link
Contributor

ahg-g commented Mar 28, 2022

wow, just like that!!!

can you show a screenshot?

@alculquicondor
Copy link
Contributor Author

~kueue_src ⮞ k get workloads       
NAME               QUEUE   ADMITTED BY     AGE
sample-job-sl4bm   main    cluster-total   5m54s

~kueue_src ⮞ k get queues
NAME   CLUSTERQUEUE    PENDING WORKLOADS
main   cluster-total   

~kueue_src ⮞ k get clusterqueues        
NAME            COHORT   PENDING WORKLOADS
cluster-total            0

~kueue_src ⮞ k get clusterqueues -o wide
NAME            COHORT   STRATEGY     PENDING WORKLOADS   ADMITTED WORKLOADS
cluster-total            StrictFIFO   0                   0

@ahg-g
Copy link
Contributor

ahg-g commented Mar 28, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahg-g,alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9346455 into kubernetes-sigs:main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants