[MultiKueue] Default managedBy for ClusterQueues configured to use MultiKueue AC #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @vladikkuzn. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vladikkuzn
force-pushed
the
job-set-default-managed-by
branch
from
4a9f756 to
6ccf00e
Compare
|
/cc @trasc |
|
/assign @trasc |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
vladikkuzn
force-pushed
the
job-set-default-managed-by
branch
from
6ccf00e to
90fb7b4
Compare
k8s-ci-robot
added
size/L
vladikkuzn
force-pushed
the
job-set-default-managed-by
branch
from
90fb7b4 to
16400e1
Compare
vladikkuzn
commented
Apr 25, 2024
vladikkuzn
force-pushed
the
job-set-default-managed-by
branch
from
16400e1 to
d424a58
Compare
|
/retest |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @mimowo |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0b2331f5ea5d38361d828bd3c53210963499ec79
|
mimowo
reviewed
May 8, 2024
k8s-ci-robot
removed
the
lgtm
vladikkuzn
force-pushed
the
job-set-default-managed-by
branch
from
e0e3fd9 to
8ba9d77
Compare
tenzen-y
reviewed
May 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, tenzen-y, vladikkuzn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
vladikkuzn
force-pushed
the
job-set-default-managed-by
branch
from
b0ca526 to
264ca52
Compare
…ntrollerName * Use cmp for comparison * Renaming * Add queue.QueueKey to generate a queue key
* Test for user-provided manage-by * Add log when managed by is overridden
vladikkuzn
force-pushed
the
job-set-default-managed-by
branch
from
264ca52 to
d752536
Compare
* Return nil instead of break * Doc update
vladikkuzn
force-pushed
the
job-set-default-managed-by
branch
from
d752536 to
a171146
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 91d24b27c1ac2773c09c8b4754ea9ca5c39f3841
|
|
/release-note-edit |
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
…ltiKueue AC (kubernetes-sigs#2048) * * Set jobSet's ManagedBy field by default if it's managed by MultiKueue * * Don't set managed by if it's already set and not jobsetapi.JobSetControllerName * Use cmp for comparison * Renaming * Add queue.QueueKey to generate a queue key * * Doc update * * Extract canOverrideManagedBy * Test for user-provided manage-by * Add log when managed by is overridden * * Add AdmissionChecksForClusterQueue to use less read locks * * Update Example JobSet section in jobsets doc * * Remove Cache.ClusterQueue * Return nil instead of break * Doc update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Sets jobSet's ManagedBy field by default if it's managed by MultiKueue
Which issue(s) this PR fixes:
Fixes #2022
Special notes for your reviewer:
Does this PR introduce a user-facing change?