-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce preemptions within ClusterQueue when preemption with borrowing is enabled #2110
Reduce preemptions within ClusterQueue when preemption with borrowing is enabled #2110
Conversation
… is enabled Change-Id: I4153eb526354d0a8cd5487b47753e5a5f2213482
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you!
/lgtm
LGTM label has been added. Git tree hash: 23144ae7c729a2d27bf3dcc8bb8e5c4b5f6aa381
|
… is enabled (kubernetes-sigs#2110) Change-Id: I4153eb526354d0a8cd5487b47753e5a5f2213482
What type of PR is this?
/kind bug
What this PR does / why we need it:
This is the same bug as #1974, but for the case when borrowing is enabled.
I followed the same approach as #1979: exclude workloads from other CQs that are not above the threshold, to avoid hitting this conditional:
kueue/pkg/scheduler/preemption/preemption.go
Line 219 in 8b7dea3
Which issue(s) this PR fixes:
Fixes #1974
Special notes for your reviewer:
Does this PR introduce a user-facing change?