Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: note how to install cert-manager #239

Merged

Conversation

knight42
Copy link
Member

Signed-off-by: Jian Zeng anonymousknight96@gmail.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:

We depends on cert-manager to handle webhook server certificates now, so we need to tell users to make user cert-manager has been installed before using kueue.

Which issue(s) this PR fixes:

Ref #232

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 30, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2022
@knight42
Copy link
Member Author

/assign @alculquicondor

Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Please squash

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, knight42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2022
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
@knight42 knight42 force-pushed the doc/install-cert-manager branch from 41392a7 to 56d98d5 Compare May 2, 2022 17:36
@knight42
Copy link
Member Author

knight42 commented May 2, 2022

@alculquicondor Squashed 🚀

@alculquicondor
Copy link
Contributor

/lgtm

Do you plan to work on the internal certificate issuing?

It's preferred that the installation of cert-manager is optional.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4ec686f into kubernetes-sigs:main May 2, 2022
@knight42 knight42 deleted the doc/install-cert-manager branch May 10, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants